Merge branch 'main' into localized-mini-tocs-bugfix

Author: gracepark

components/Header.tsx

@@ -34,7 +34,7 @@ export const Header = () => {
         style={{ zIndex: 2 }}
       >
         {/* desktop header */}
-        <div className="d-none d-lg-flex flex-justify-end">
+        <div className="d-none d-lg-flex flex-justify-end" data-testid="desktop-header">
           {showVersionPicker && (
             <div className="py-2 mr-4">
               <HomepageVersionPicker />
@@ -54,7 +54,7 @@ export const Header = () => {
         </div>
 
         {/* mobile header */}
-        <div className="d-lg-none">
+        <div className="d-lg-none" data-testid="mobile-header">
           <div className="d-flex flex-justify-between">
             <div className="d-flex flex-items-center" id="github-logo-mobile" role="banner">
               <Link aria-hidden="true" tabIndex={-1} href={`/${router.locale}`}>
@@ -71,6 +71,7 @@ export const Header = () => {
 
             <div>
               <ButtonOutline
+                data-testid="mobile-menu-button"
                 css
                 onClick={() => setIsMenuOpen(!isMenuOpen)}
                 aria-label="Navigation Menu"

components/Search.tsx

@@ -5,6 +5,7 @@ import { useTranslation } from 'components/hooks/useTranslation'
 import { sendEvent, EventType } from '../javascripts/events'
 import { useMainContext } from './context/MainContext'
 import { useVersion } from 'components/hooks/useVersion'
+import cx from 'classnames'
 
 type SearchResult = {
   url: string
@@ -193,8 +194,9 @@ export function Search({ isStandalone = false, updateSearchParams = true, childr
       <div className="ais-SearchBox">
         <form role="search" className="ais-SearchBox-form" noValidate onSubmit={preventRefresh}>
           <input
+            data-testid="site-search-input"
             ref={inputRef}
-            className={'ais-SearchBox-input' + (isStandalone || query ? ' js-open' : '')}
+            className={cx('ais-SearchBox-input', isStandalone || query ? 'js-open' : '')}
             type="search"
             placeholder={t`placeholder`}
             /* eslint-disable-next-line jsx-a11y/no-autofocus */

components/SidebarNav.tsx

@@ -55,6 +55,7 @@ export const SidebarNav = () => {
             width: 280px;
             height: 100vh;
             flex-shrink: 0;
+            padding-bottom: 32px;
           }
         `}
       </style>

components/context/MainContext.tsx

@@ -118,7 +118,7 @@ export const getMainContextFromRequest = (req: any): MainContextT => {
     currentProduct: req.context.productMap[req.context.currentProduct] || null,
     currentLayoutName: req.context.currentLayoutName,
     isHomepageVersion: req.context.currentVersion === 'homepage',
-    error: req.context.error || '',
+    error: req.context.error ? req.context.error.toString() : '',
     data: {
       ui: req.context.site.data.ui,
       reusables: {

components/context/ProductLandingContext.tsx

@@ -79,7 +79,7 @@ export const getFeaturedLinksFromReq = (req: any): Record<string, Array<Featured
     Object.entries(req.context.featuredLinks || {}).map(([key, entries]) => {
       return [
         key,
-        (entries as Array<any> || []).map((entry: any) => ({
+        ((entries as Array<any>) || []).map((entry: any) => ({
           href: entry.href,
           title: entry.title,
           intro: entry.intro,
@@ -144,7 +144,7 @@ export const getProductLandingContextFromRequest = (req: any): ProductLandingCon
               ? req.context.page.featuredLinks.popularHeading || req.context.site.data.ui.toc[key]
               : req.context.site.data.ui.toc[key],
           viewAllHref:
-            key === 'guides' && !req.context.currentCategory && hasGuidesPage 
+            key === 'guides' && !req.context.currentCategory && hasGuidesPage
               ? `${req.context.currentPath}/guides`
               : '',
           articles: links.map((link: any) => {

components/landing/ArticleList.tsx

@@ -41,7 +41,7 @@ export const ArticleList = ({
         </div>
       )}
 
-      <ul className="list-style-none">
+      <ul className="list-style-none" data-testid="article-list">
         {articles.map((link) => {
           return (
             <li key={link.href} className={cx(variant === 'compact' && 'border-top')}>

components/landing/CodeExampleCard.tsx

@@ -9,6 +9,7 @@ export const CodeExampleCard = ({ example }: Props) => {
   return (
     <a
       className="Box d-flex flex-column flex-justify-between height-full color-shadow-medium hover-shadow-large no-underline color-text-primary"
+      data-testid="code-example-card"
       href={`https://github.com/${example.href}`}
     >
       <div className="p-4">

components/landing/CodeExamples.tsx

@@ -32,6 +32,7 @@ export const CodeExamples = () => {
     <div>
       <div className="pr-lg-3 mb-5 mt-3">
         <input
+          data-testid="code-examples-input"
           className="input-lg py-2 px-3 col-12 col-lg-8 form-control"
           placeholder={t('search_code_examples')}
           type="search"
@@ -53,6 +54,7 @@ export const CodeExamples = () => {
 
       {numVisible < productCodeExamples.length && !isSearching && (
         <button
+          data-testid="code-examples-show-more"
           className="btn btn-outline float-right"
           onClick={() => setNumVisible(numVisible + PAGE_SIZE)}
         >
@@ -61,7 +63,10 @@ export const CodeExamples = () => {
       )}
 
       {isSearching && searchResults.length === 0 && (
-        <div className="py-4 text-center color-text-secondary font-mktg">
+        <div
+          data-testid="code-examples-no-results"
+          className="py-4 text-center color-text-secondary font-mktg"
+        >
           <div className="mb-3">
             <SearchIcon size={24} />{' '}
           </div>

components/landing/LandingSection.tsx

@@ -12,7 +12,13 @@ export const LandingSection = ({ title, children, className, sectionLink, descri
     <div className={cx('container-xl px-3 px-md-6', className)} id={sectionLink}>
       {title && (
         <h2 className={cx('font-mktg h1 color-text-primary', !description ? 'mb-3' : 'mb-4')}>
-          {sectionLink ? <a className="color-unset" href={`#${sectionLink}`}>{title}</a> : title}
+          {sectionLink ? (
+            <a className="color-unset" href={`#${sectionLink}`}>
+              {title}
+            </a>
+          ) : (
+            title
+          )}
         </h2>
       )}
       {description && (

components/landing/ProductArticlesList.tsx

@@ -16,7 +16,7 @@ export const ProductArticlesList = () => {
   }
 
   return (
-    <div className="d-flex gutter flex-wrap">
+    <div className="d-flex gutter flex-wrap" data-testid="product-articles-list">
       {currentProductTree.childPages.map((treeNode, i) => {
         if (treeNode.page.documentType === 'article') {
           return null
@@ -34,7 +34,9 @@ const ProductTreeNodeList = ({ treeNode }: { treeNode: ProductTreeNode }) => {
   return (
     <div className="col-12 col-lg-4 mb-6 height-full">
       <h4 className="mb-3">
-        <Link className="color-unset" href={treeNode.href}>{treeNode.renderedFullTitle}</Link>
+        <Link className="color-unset" href={treeNode.href}>
+          {treeNode.renderedFullTitle}
+        </Link>
       </h4>
 
       <ul className="list-style-none">

components/landing/ProductLanding.tsx

@@ -37,7 +37,11 @@ export const ProductLanding = () => {
       </LandingSection>
 
       {productCodeExamples.length > 0 && (
-        <LandingSection title={t('code_examples')} sectionLink="code-examples" className="my-6 pb-6">
+        <LandingSection
+          title={t('code_examples')}
+          sectionLink="code-examples"
+          className="my-6 pb-6"
+        >
           <CodeExamples />
         </LandingSection>
       )}
@@ -68,7 +72,7 @@ export const ProductLanding = () => {
         </div>
       )}
 
-      <LandingSection title={`All ${shortTitle} docs`} sectionLink="all-docs"  className="pt-9">
+      <LandingSection title={`All ${shortTitle} docs`} sectionLink="all-docs" className="pt-9">
         <ProductArticlesList />
       </LandingSection>
     </DefaultLayout>

content/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/managing-encrypted-secrets-for-dependabot.md

@@ -79,3 +79,7 @@ When creating a secret in an organization, you can use a policy to limit which r
    The name of the secret is listed on the Dependabot secrets page. You can click **Update** to change the secret value or its access policy. You can click **Remove** to delete the secret.
 
    ![Update or remove an organization secret](/assets/images/help/dependabot/update-remove-repo-secret.png)
+   
+## Adding {% data variables.product.prodname_dependabot %} to your registries IP allow list
+
+If your private registry is configured with an IP allow list, you can find the IP addresses {% data variables.product.prodname_dependabot %} uses to access the registry in the meta API endpoint, under the `dependabot` key. For more information, see "[Meta](/rest/reference/meta)."

data/release-notes/enterprise-server/2-20/0.yml

@@ -41,3 +41,4 @@ sections:
     - 'When upgrading from previous versions, background job workers may not be spawned, preventing essential features such as merging pull requests. (updated 2020-04-07) {% comment %} https://github.com/github/enterprise2/issues/19232 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. (updated 2020-06-23) {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
     - 'Dependency graph is not detecting dependencies when deployed in a cluster configuration with multiple Redis nodes. (updated 2020-06-30) {% comment %} https://github.com/github/dependency-graph/issues/81 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/1.yml

@@ -18,3 +18,4 @@ sections:
     - 'When upgrading from previous versions, background job workers may not be spawned, preventing essential features such as merging pull requests. (updated 2020-04-07) {% comment %} https://github.com/github/enterprise2/issues/19232 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. (updated 2020-06-23) {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
     - 'Dependency graph is not detecting dependencies when deployed in a cluster configuration with multiple Redis nodes. (updated 2020-06-30) {% comment %} https://github.com/github/dependency-graph/issues/81 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/10.yml

@@ -18,3 +18,4 @@ sections:
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
     - 'Dependency graph is not detecting dependencies when deployed in a cluster configuration with multiple Redis nodes. (updated 2020-06-30) {% comment %} https://github.com/github/dependency-graph/issues/81 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/11.yml

@@ -16,3 +16,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/12.yml

@@ -14,3 +14,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/13.yml

@@ -19,3 +19,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/14.yml

@@ -10,3 +10,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/15.yml

@@ -22,3 +22,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/16.yml

@@ -10,3 +10,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/17.yml

@@ -10,3 +10,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/18.yml

@@ -23,3 +23,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'

data/release-notes/enterprise-server/2-20/19.yml

@@ -11,3 +11,4 @@ sections:
     - 'Issues cannot be closed if they contain a permalink to a blob in the same repository where the file path is longer than 255 characters. {% comment %} https://github.com/github/github/issues/107731 {% endcomment %}'
     - 'When "Users can search GitHub.com" is enabled with GitHub Connect, issues in private and internal repositories are not included in GitHub.com search results. {% comment %} https://github.com/github/admin-experience/issues/571 {% endcomment %}'
     - 'Security alerts are not reported when pushing to a repository on the command line. {% comment %} https://github.com/github/github/issues/143190 {% endcomment %}'
+    - 'When a replica node is offline in a high availability configuration, {% data variables.product.product_name %} may still route {% data variables.product.prodname_pages %} requests to the offline node, reducing the availability of {% data variables.product.prodname_pages %} for users.'