-
Notifications
You must be signed in to change notification settings - Fork 38
[PT1-92] added automation scripts #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds deployment automation infrastructure with a comprehensive Makefile and refactors the KYC-NFT deployment script to use externalized configuration constants instead of hardcoded values.
- Introduces a Makefile with deployment automation, validation, and utility targets
- Refactors deployment script to use dynamic configuration from constants files
- Creates modular constants structure for network-specific deployment parameters
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/deploy-kyc-nft.js | Refactored to use dynamic constants and improved chain validation |
| deploy/constants/index.js | Main constants module exporting deployment configuration |
| deploy/constants/create3-deployer.js | CREATE3 deployer addresses for multiple networks |
| deploy/constants/access-token-salt.js | Network-specific salt values for access token deployment |
| deploy/constants/access-token-owner.js | Network-specific owner addresses for access tokens |
| Makefile | Comprehensive automation script for deployment, validation, and utilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 7 7
Lines 173 173
Branches 33 33
=======================================
Hits 136 136
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change Summary
What does this PR change?
Adds deployment automation (Makefile) and updates the
deploy/deploy-kyc-nft.jswith the new deployment mechanism.Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact
No migrations, downtime, or breaking changes expected.