Merge pull request #32 from 1pkg/use_some_defaults_from_go_env

use some default envs from go env

Author: 1pkg

extensions/vscode/package.json

@@ -7,7 +7,7 @@
 		"name": "Kostiantyn Masliuk - github.com/1pkg"
 	},
 	"license": "MIT",
-	"version": "1.6.3",
+	"version": "1.7.0",
 	"categories": [
 		"Programming Languages",
 		"Formatters",

gopium/opium.go

@@ -3,7 +3,7 @@ package gopium
 // list of global registered gopium constants
 const (
 	NAME    = "gopium"
-	VERSION = "1.6.3"
+	VERSION = "1.7.0"
 	PKG     = "https://github.com/1pkg/gopium"
 	STAMP   = "🌺 gopium @1pkg"
 )

main.go

@@ -2,11 +2,14 @@ package main
 
 import (
 	"context"
+	"fmt"
 	"log"
 	"os"
+	"os/exec"
 	"os/signal"
 	"path/filepath"
 	"runtime"
+	"strings"
 
 	"github.com/1pkg/gopium/gopium"
 	"github.com/1pkg/gopium/runners"
@@ -161,7 +164,7 @@ Notes:
 				// package parser vars
 				args[1], // package name
 				ppath,
-				pbenvs,
+				defenv(cmd.Context(), pbenvs, "GOPATH", "GOCACHE", "GOTMPDIR"),
 				pbflags,
 				// gopium walker vars
 				args[0], // single walker
@@ -317,6 +320,23 @@ By default it is used and overrides other printer formatting parameters.
 	)
 }
 
+// defenv appends requested env variable from `go env`, if no custom variable provided
+func defenv(ctx context.Context, envs []string, vars ...string) []string {
+loop:
+	for _, v := range vars {
+		for _, env := range envs {
+			if strings.HasPrefix(env, v) {
+				continue loop
+			}
+		}
+		ebytes, err := exec.CommandContext(ctx, "go", "env", v).CombinedOutput()
+		if err == nil {
+			envs = append(envs, fmt.Sprintf("%s=%s", v, strings.TrimSpace(string(ebytes))))
+		}
+	}
+	return envs
+}
+
 // main gopium cli entry point
 func main() {
 	// explicitly set number of threads

runners/cli.go

@@ -74,13 +74,6 @@ func NewCli(
 	if !filepath.IsAbs(path) {
 		root = build.Default.GOPATH
 	}
-	// https://github.com/1pkg/gopium/issues/18
-	if len(benvs) == 0 {
-		benvs = []string{
-			fmt.Sprintf("GOPATH=%s", build.Default.GOPATH),
-			fmt.Sprintf("GOCACHE=%s", filepath.Join(build.Default.GOPATH, ".cache")),
-		}
-	}
 	// set up parser
 	xp := &typepkg.ParserXToolPackagesAst{
 		Pattern: pkg,

runners/cli_test.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"go/build"
 	"go/parser"
-	"path/filepath"
 	"reflect"
 	"regexp"
 	"testing"
@@ -90,12 +89,9 @@ func TestNewCli(t *testing.T) {
 						Root:    build.Default.GOPATH,
 						Path:    "test-path",
 						//nolint
-						ModeTypes: packages.LoadAllSyntax,
-						ModeAst:   parser.ParseComments | parser.AllErrors,
-						BuildEnv: []string{
-							fmt.Sprintf("GOPATH=%s", build.Default.GOPATH),
-							fmt.Sprintf("GOCACHE=%s", filepath.Join(build.Default.GOPATH, ".cache")),
-						},
+						ModeTypes:  packages.LoadAllSyntax,
+						ModeAst:    parser.ParseComments | parser.AllErrors,
+						BuildEnv:   []string{},
 						BuildFlags: []string{},
 					},
 					Exposer: m,
@@ -143,12 +139,9 @@ func TestNewCli(t *testing.T) {
 						Root:    build.Default.GOPATH,
 						Path:    "test-path",
 						//nolint
-						ModeTypes: packages.LoadAllSyntax,
-						ModeAst:   parser.ParseComments | parser.AllErrors,
-						BuildEnv: []string{
-							fmt.Sprintf("GOPATH=%s", build.Default.GOPATH),
-							fmt.Sprintf("GOCACHE=%s", filepath.Join(build.Default.GOPATH, ".cache")),
-						},
+						ModeTypes:  packages.LoadAllSyntax,
+						ModeAst:    parser.ParseComments | parser.AllErrors,
+						BuildEnv:   []string{},
 						BuildFlags: []string{},
 					},
 					Exposer: m,