Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persian_leap issue #8

Open
hamidghiasifar opened this issue Feb 7, 2025 · 1 comment
Open

persian_leap issue #8

hamidghiasifar opened this issue Feb 7, 2025 · 1 comment

Comments

@hamidghiasifar
Copy link

Esfand 1403 is showing 29 days, it is a leap year and it should be 30 days, this will cause the next year to be shown incorrectly.

@1saeedsalehi
Copy link
Owner

1saeedsalehi commented Feb 9, 2025

I see an issue with calculating leap years in the Persian calendar.

There are two common methods for determining leap years:

  • Astronomical Method – Based on the actual number of days between equinoxes at the reference meridian.
  • Algorithmic Method – Based on Ahmad Birashk's proposed algorithm.

The problem lies in the algorithmic approach. I'll investigate further and provide an update on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants