Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip install step to CI #5

Merged
merged 1 commit into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions .github/workflows/spz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,19 @@ jobs:
if: runner.os == 'Linux'
run: |
sudo apt-get update
sudo apt-get install -y build-essential cmake ninja-build
sudo apt-get install -y build-essential cmake ninja-build python3-pip

- name: Set up C++ environment on macOS
if: runner.os == 'macOS'
run: |
brew update
brew install cmake ninja
brew install cmake ninja python3

- name: Set up Python 3.10 on Windows
if: runner.os == 'Windows'
uses: actions/setup-python@v5
with:
python-version: '3.10'

- name: Configure CMake with MSBuild (Windows)
if: runner.os == 'Windows'
Expand All @@ -57,3 +63,15 @@ jobs:
- name: Build with Ninja (Linux/macOS)
if: runner.os != 'Windows'
run: cmake --build build --parallel

- name: Install Python spz package on macOS using a virtual environment
if: runner.os == 'macOS'
run: |
python3 -m venv venv
source venv/bin/activate
pip install --upgrade pip
pip install .

- name: Install Python spz package on Linux/Windows using pip
if: runner.os != 'macOS'
run: pip3 install .
2 changes: 1 addition & 1 deletion src/cc/load-spz.cc
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ bool saveSpz(const GaussianCloud &g, std::vector<uint8_t> *out,
data = ss.str();
}
return compressZstd(reinterpret_cast<const uint8_t *>(data.data()),
data.size(), out, compressionLevel);
data.size(), out, compressionLevel, workers);
}

PackedGaussians loadSpzPacked(const uint8_t *data, int size) {
Expand Down
Loading