diff --git a/obs/preinstallimage-bios.sh.in b/obs/preinstallimage-bios.sh.in index e45f1f4dc..1d6ad821a 100755 --- a/obs/preinstallimage-bios.sh.in +++ b/obs/preinstallimage-bios.sh.in @@ -367,6 +367,9 @@ mkdir -p /etc/network # The IPC loader renames interfaces to LANx pattern, current OVA one does not FIRSTIFNAME="`file -b /bin/bash | sed -e 's|.*x86-64.*|eth0|' -e 's|.*ARM.*|LAN1|'`" mkdir -p /etc/network/interfaces.d + +## Review1: obsolete debian version +## Proposal1: remove it and keep the default case case "$OSIMAGE_DISTRO" in Debian_8.0) # syntax not supported, parsing the lines below fails # in main file, spews errors but proceeds in included config @@ -385,17 +388,8 @@ cat > /etc/network/interfaces < /etc/resolv.conf <&2 fi +## Review5: 'Pool\:/master' does not exist !!!! +## Proposal5: should be craeted on OBS ? how? # Append the (currently internal) OBS source of built packages: # Note: do not change the 'Pool\:/master' reference below because it may be # substituted to corresponding actual repository during OBS image creation. @@ -486,6 +487,9 @@ case "$IMGTYPE" in esac # This may be not available on space-constrained deploy images +## Review6: apt-key is deprecated +## Proposal6: should use gpg to add repository keys +##question6: which repo key ? if command -v apt-key >/dev/null ; then cat << EOF | apt-key add - -----BEGIN PGP PUBLIC KEY BLOCK----- @@ -865,7 +869,15 @@ esac # Enable 42ity services (distributed as a systemd preset file) # NOTE that in Debian 10 this seems to also process ALL service files -# found in the system, not just presets. +## found in the system, not just presets. +## Review7: some services don't exist +## Proposal7: for which reason? somethting to do remove them or create them? +## [ 139s] Failed to disable unit, unit lcd-boot-display.service does not exist. +## [ 139s] Failed to disable unit, unit lcd-net-display.service does not exist. +## [ 139s] Failed to disable unit, unit lcd-shutdown-display.service does not exist. +## [ 139s] Failed to disable unit, unit lcd-shutdown-inverse-display.service does not exist. +## [ 139s] Failed to disable unit, unit lcd-reboot-display.service does not exist. +## [ 139s] Failed to disable unit, unit lcd-poweroff-display.service does not exist /bin/systemctl preset-all if [ "`uname -m`" = x86_64 ]; then /bin/systemctl disable lcd-boot-display || true @@ -891,6 +903,9 @@ else /bin/systemctl enable lcd-poweroff-display || true #sed -i 's|PathChanged=/etc|PathChanged=/mnt/nand/overlay/etc|' /usr/lib/systemd/system/composite-metrics\@.path fi +## Review8: some services don't exist +## Proposal8:for which reason? somethting to do remove them or create them? +##[ 139s] Failed to disable unit, unit tntnet@.service does not exist. # Our tntnet unit rocks, disable packaged default if [ -s /lib/systemd/system/fty-tntnet@.service ]; then @@ -1172,6 +1187,9 @@ fi install -m 0755 /usr/share/fty/scripts/curlbbwget.sh /usr/bin/curl ######################################################################### +## Review9: check this agent ? +## Proposal9: -- + # Setup zabbix # TODO: revise the list of 42ity services here if [ -f /usr/bin/zabbix_agent ]; then