-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use standard Visual Studio Build system #85
Comments
As far as I can tell Microsoft is dropping the project.json format. https://www.infoq.com/news/2016/05/project-json Maybe it is a good idea to switch back to csproj files |
I changed the project.json to
and I got further. The properties window for the project can now be shown. But now I get the following errors.
|
Thanks for considering contributing to the library! Short answer: we are using proper Visual Studio project and build systems and patterns. I actually worked on the VS project & build team for 7 years as recently as last year. 😄
That's fine, although not strictly necessary. You can build after a package restore from the command line without it. The build errors you're seeing around missing methods in libgit2sharp are bizarre. I've never seen those. My best guess is you are using an msbuild node that previously loaded libgit2sharp for some other reason, and it was a different version of it. Try using all new msbuild nodes (using the The errors in resolving references are all from the project system (more bugs in it). The build works just fine both in VS and the command line on my machine and on appveyor, which has no special software installed.
This screenshot of a failed project designer page is a bug in the C# project system. And yes, it has to do with some element of the project.json file although I was never sure quite which one it was. suppressParent is nonetheless important to keep because it means some of our dependencies propagate including their msbuild imports. I generally find ways to avoid the project designer anyway so it's not much of an issue.
We are already using msbuild project files. This isn't the project.json files that replace MSBuild like in ASP.NET (or packaging projects) case. And the new project.json-less MSBuild feature Microsoft is talking about hasn't been delivered yet.
That's because you removed |
We can leave this issue open while we collaborate to get you unblocked. |
OK I'll give it another spin tomorrow. On Tue, 16 Aug 2016, 16:41 Andrew Arnott, [email protected] wrote:
|
I deleted the directory then started from scratch
The full build log for msbuild is at
but the critical error is
|
Which version of NuGet.exe are you using? Try 3.3.0 if you're not using that. |
NuGet Version: 3.4.3.855 Can you please check the version of nuget you wish to use into a tools directory? As well if I build from the command line I get only the one error above. If I After building in VS and getting the 60 errors if I switch back to the command The VS errors I get when building are
|
The feature I want to try to contribute to is. #84 as we have our own that I could port. |
Nuget.exe isn't something you installed, I suppose, is it? Didn't you just download the .exe? Uninstallation isn't required.
nuget.exe and the nuget functionality within VS has been extremely turbulent with feature gaps and bugs. The one you're using (3.4.3) is one of the buggiest. 3.3.0 had a really good combination of features and stability. 3.4.4 is ok but it has its own regressions that must be worked around. NuGet support in VS itself is full of holes.
You're absolutely right. At the time I was actively working on this project, 3.3.0 was the latest version and I didn't really need to worry (or so I thought). Since then, the nuget team kept releasing broken release after broken release, and most of the projects I actively work on have scripts to automate acquisition of the compatible version of nuget.exe and a guidance doc that tells you how to workaround VS's own bugs. This project lacks that. I'll resolve this issue when I update this project to follow those patterns so it's easier for folks to onboard to this project. |
I just realized my contribution.md doc already mentions that nuget 3.3.0 is required. Did you read it before filing this issue? |
I see I have not read your docs properly :( I have created a tools directory and added nuget.exe 3.3.0 to it. It's only 3k. Is there a big reason not to check it in? The build now works. Thanks for the pointers. |
3k? or 3.3MB. I see it as 3.3MB. Watch for a commit in a moment. I've got it going. I don't like checking in binaries, but it turns out that's not necessary. |
It still doesn't build from VS though. |
Did you follow the contrib guidance I added in that commit? |
ok I'll read some more. I'm not sure I need to commit directly to the project anyway. I can create a dependent nuget package. |
I've created a dependent project to do my experiments with. I don't need to add these feature currently directly to your source. But you may be interested in the progress or contribute some ideas yourself. |
I was hoping to add some contributions to the project but have trouble with your non standard build system.
I've installed nuproj but there are various errors after building. For example.
the project references are broken. I get the following warnings
When I try to look at the project properties for ImmutableObjectGraph(Portable) I see the following error.
My colleauge thinks this has something to do with the "suppresParent" field in the project.json file but we are not sure what removing this field might do to the build.
The text was updated successfully, but these errors were encountered: