Merge pull request #460 from AVSLab/ci/bsk-458--check-pip-process-returncode

Check pip upgrade return code

Author: patkenneally

conanfile.py

@@ -299,11 +299,12 @@ def add_basilisk_to_sys_path(self):
 
         process = subprocess.Popen(add_basilisk_module_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
         output, err = process.communicate()
-        if err:
+        if process.returncode:
             print("Error %s while running %s" % (err.decode(), add_basilisk_module_command))
             sys.exit(1)
         else:
-            print("This resulted in the output: \n%s" % output.decode())
+            print("This resulted in the stdout: \n%s" % output.decode())
+            print("This resulted in the stderr: \n%s" % err.decode())
 
 if __name__ == "__main__":
     parser = argparse.ArgumentParser(description="Configure the Basilisk framework.")

docs/source/Support/bskReleaseNotes.rst

@@ -65,10 +65,12 @@ Version |release|
   and angular rate (optional) are within the requirement limits and sends an imaging command to a :ref:`simpleInstrument`.
 - Added a new scenario :ref:`scenarioHohmann` that performs a Hohmann transfer with attitude mode changes.
   The basic attitude flight modes are implemented using the Basilisk event system.
-- updated conan support to latest `1.xx` version to provide support for macOS Sonoma
-- updated macOS `cspice` library to be compiled with Xcode 15.  This addresses some errors that appeared
-  when calling the prior pre-built `cspice` library.  The new library is backwards compatible with
+- updated conan support to latest ``1.xx`` version to provide support for macOS Sonoma
+- updated macOS ``cspice`` library to be compiled with Xcode 15.  This addresses some errors that appeared
+  when calling the prior pre-built ``cspice`` library.  The new library is backwards compatible with
   prior versions of Xcode.
+- Fixed a bug in the conanfile where the ``stderr`` output from a ``subprocess.Popen`` call was being interpreted as an
+  error. Rather, the process return code (0 for success, and anything else for failure) indicates the success.
 
 
 Version 2.2.0 (June 28, 2023)