Monix extensions - move broken test to jvm only

Author: sebaciv

core/jvm/src/test/scala/com/avsystem/commons/concurrent/JvmTaskExtensionsTest.scala

@@ -0,0 +1,26 @@
+package com.avsystem.commons
+package concurrent
+
+import monix.eval.Task
+import monix.execution.Scheduler
+import org.scalatest.concurrent.ScalaFutures
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+import org.scalatestplus.scalacheck.ScalaCheckDrivenPropertyChecks
+
+import scala.concurrent.TimeoutException
+import scala.concurrent.duration._
+
+class JvmTaskExtensionsTest extends AnyFunSuite with Matchers with ScalaCheckDrivenPropertyChecks with ScalaFutures {
+
+  import com.avsystem.commons.concurrent.TaskExtensions._
+
+  private implicit val scheduler: Scheduler = Scheduler.global
+
+  // This test does not work in SJS runtime (but the method itself does)
+  test("lazyTimeout") {
+    val result = Task.never.lazyTimeout(50.millis, "Lazy timeout").runToFuture.failed.futureValue
+    result shouldBe a[TimeoutException]
+    result.getMessage shouldBe "Lazy timeout"
+  }
+}

core/src/main/scala/com/avsystem/commons/concurrent/TaskExtensions.scala

@@ -4,6 +4,7 @@ package concurrent
 import com.avsystem.commons.concurrent.TaskExtensions.{TaskCompanionOps, TaskOps}
 import com.avsystem.commons.misc.Timestamp
 import monix.eval.Task
+import monix.reactive.Observable
 
 import java.util.concurrent.TimeUnit
 import scala.concurrent.TimeoutException
@@ -37,6 +38,8 @@ object TaskExtensions extends TaskExtensions {
   }
 
   object TaskCompanionOps {
+    import com.avsystem.commons.concurrent.ObservableExtensions.observableOps
+
     /** A [[Task]] of [[Opt.Empty]] */
     def optEmpty[A]: Task[Opt[A]] = Task.pure(Opt.Empty)
 
@@ -49,7 +52,7 @@ object TaskExtensions extends TaskExtensions {
     }
 
     def traverseMap[K, V, A, B](map: Map[K, V])(f: (K, V) => Task[(A, B)]): Task[Map[A, B]] =
-      Task.traverse(map.toSeq)({ case (key, value) => f(key, value) }).map(_.toMap)
+      Observable.fromIterable(map).mapEval({ case (key, value) => f(key, value) }).toL(Map)
 
     def traverseMapValues[K, A, B](map: Map[K, A])(f: (K, A) => Task[B]): Task[Map[K, B]] =
       traverseMap(map)({ case (key, value) => f(key, value).map(key -> _) })

core/src/test/scala/com/avsystem/commons/concurrent/TaskExtensionsTest.scala

@@ -8,20 +8,11 @@ import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
 import org.scalatestplus.scalacheck.ScalaCheckDrivenPropertyChecks
 
-import scala.concurrent.TimeoutException
-import scala.concurrent.duration._
-
 class TaskExtensionsTest extends AnyFunSuite with Matchers with ScalaCheckDrivenPropertyChecks with ScalaFutures {
   import com.avsystem.commons.concurrent.TaskExtensions._
 
   private implicit val scheduler: Scheduler = Scheduler.global
 
-  test("lazyTimeout") {
-    val result = Task.never.lazyTimeout(50.millis, "Lazy timeout").runToFuture.failed.futureValue
-    result shouldBe a[TimeoutException]
-    result.getMessage shouldBe "Lazy timeout"
-  }
-
   test("traverseOpt") {
     Task.traverseOpt(Opt.empty[Int])(i => Task.now(i)).runToFuture.futureValue shouldBe Opt.Empty
     Task.traverseOpt(Opt.some(123))(i => Task.now(i)).runToFuture.futureValue shouldBe Opt.some(123)