Skip to content

Commit 0ceb148

Browse files
committed
#837 Make COMP-3 with scale factor tests stricter.
1 parent 0871fcf commit 0ceb148

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

cobol-parser/src/test/scala/za/co/absa/cobrix/cobol/parser/decoders/BinaryDecoderSpec.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,22 +228,22 @@ class BinaryDecoderSpec extends AnyFunSuite {
228228

229229
test("Test COMP-3 decimal with scale factor cases") {
230230
val v1 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x06.toByte,0x54.toByte,0x7C.toByte), scale = 0, scaleFactor = 0, mandatorySignNibble = true)
231-
assert (v1.contains("06547"))
231+
assert (v1 == "06547")
232232

233233
val v2 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x06.toByte,0x54.toByte,0x7C.toByte), scale = 0, scaleFactor = -1, mandatorySignNibble = true)
234-
assert (v2.contains("0.006547"))
234+
assert (v2 == "0.006547")
235235

236236
val v3 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x06.toByte,0x54.toByte,0x7C.toByte), scale = 0, scaleFactor = -2, mandatorySignNibble = true)
237-
assert (v3.contains("0.0006547"))
237+
assert (v3 == "0.0006547")
238238

239239
val v4 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x06.toByte,0x54.toByte,0x7C.toByte), scale = 5, scaleFactor = -1, mandatorySignNibble = true)
240-
assert (v4.contains("0.006547"))
240+
assert (v4 == "0.006547")
241241

242242
val v5 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x06.toByte,0x54.toByte,0x7C.toByte), scale = 5, scaleFactor = -2, mandatorySignNibble = true)
243-
assert (v5.contains("0.0006547"))
243+
assert (v5 == "0.0006547")
244244

245245
val v6 = BCDNumberDecoders.decodeBigBCDNumber(Array[Byte](0x16.toByte,0x54.toByte,0x7C.toByte), scale = 5, scaleFactor = -2, mandatorySignNibble = true)
246-
assert (v6.contains("0.0016547"))
246+
assert (v6 == "0.0016547")
247247
}
248248

249249
test("Test COMP-3U decimal cases") {

spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/source/regression/Test17NumericConversions.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,9 @@ class Test17NumericConversions extends AnyWordSpec with SparkTestBase with Binar
298298
.load(tmpFileName)
299299

300300
val actualSchema = df.schema.treeString
301-
val actualData1 = df.collect()(0).getDecimal(0).toString
302-
val actualData2 = df.collect()(0).getDecimal(1).toString
301+
val row = df.collect().head
302+
val actualData1 = row.getDecimal(0).toString
303+
val actualData2 = row.getDecimal(1).toString
303304

304305
"schema should match" in {
305306
val expectedSchema =

0 commit comments

Comments
 (0)