Skip to content

Allow for optionally disabling SSL verification. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenmcgaugh wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow for optionally disabling SSL verification. #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions include/xstudio/http_client/http_client_actor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ namespace http_client {
caf::actor_config &cfg,
time_t connection_timeout = CPPHTTPLIB_CONNECTION_TIMEOUT_SECOND,
time_t read_timeout = CPPHTTPLIB_READ_TIMEOUT_SECOND,
time_t write_timeout = CPPHTTPLIB_WRITE_TIMEOUT_SECOND);
time_t write_timeout = CPPHTTPLIB_WRITE_TIMEOUT_SECOND,
bool ssl_verify = true);
~HTTPClientActor() override = default;

const char *name() const override { return NAME.c_str(); }
Expand All @@ -30,6 +31,7 @@ namespace http_client {
time_t connection_timeout_;
time_t read_timeout_;
time_t write_timeout_;
bool ssl_verify_;
};

class HTTPWorker : public caf::event_based_actor {
Expand All @@ -38,7 +40,8 @@ namespace http_client {
caf::actor_config &cfg,
time_t connection_timeout = CPPHTTPLIB_CONNECTION_TIMEOUT_SECOND,
time_t read_timeout = CPPHTTPLIB_READ_TIMEOUT_SECOND,
time_t write_timeout = CPPHTTPLIB_WRITE_TIMEOUT_SECOND);
time_t write_timeout = CPPHTTPLIB_WRITE_TIMEOUT_SECOND,
bool ssl_verify = true);
~HTTPWorker() override = default;

const char *name() const override { return NAME.c_str(); }
Expand Down
15 changes: 11 additions & 4 deletions src/http_client/src/http_client_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ HTTPWorker::HTTPWorker(
caf::actor_config &cfg,
time_t connection_timeout,
time_t read_timeout,
time_t write_timeout)
time_t write_timeout,
bool ssl_verify)
: caf::event_based_actor(cfg) {
behavior_.assign(
[=](xstudio::broadcast::broadcast_down_atom, const caf::actor_addr &) {},
Expand All @@ -81,6 +82,7 @@ HTTPWorker::HTTPWorker(
cli.set_connection_timeout(connection_timeout, 0);
cli.set_read_timeout(read_timeout, 0);
cli.set_write_timeout(write_timeout, 0);
cli.enable_server_certificate_verification(ssl_verify);
auto res = [&]() -> httplib::Result {
if (content_type.empty())
return cli.Delete(path.c_str(), headers);
Expand Down Expand Up @@ -135,6 +137,7 @@ HTTPWorker::HTTPWorker(
cli.set_connection_timeout(connection_timeout, 0);
cli.set_read_timeout(read_timeout, 0);
cli.set_write_timeout(write_timeout, 0);
cli.enable_server_certificate_verification(ssl_verify);

// cli.set_logger([](const auto& req, const auto& res) {
// spdlog::warn("{}", req.);
Expand Down Expand Up @@ -200,6 +203,7 @@ HTTPWorker::HTTPWorker(
cli.set_connection_timeout(connection_timeout, 0);
cli.set_read_timeout(read_timeout, 0);
cli.set_write_timeout(write_timeout, 0);
cli.enable_server_certificate_verification(ssl_verify);
auto res = [&]() -> httplib::Result {
if (content_type.empty())
return cli.Post(path.c_str(), headers, params);
Expand Down Expand Up @@ -257,6 +261,7 @@ HTTPWorker::HTTPWorker(
cli.set_connection_timeout(connection_timeout, 0);
cli.set_read_timeout(read_timeout, 0);
cli.set_write_timeout(write_timeout, 0);
cli.enable_server_certificate_verification(ssl_verify);

auto res = [&]() -> httplib::Result {
if (content_type.empty())
Expand Down Expand Up @@ -311,11 +316,13 @@ HTTPClientActor::HTTPClientActor(
caf::actor_config &cfg,
time_t connection_timeout,
time_t read_timeout,
time_t write_timeout)
time_t write_timeout,
bool ssl_verify)
: caf::event_based_actor(cfg),
connection_timeout_(connection_timeout),
read_timeout_(read_timeout),
write_timeout_(write_timeout) {
write_timeout_(write_timeout),
ssl_verify_(ssl_verify) {
init();
}

Expand All @@ -339,7 +346,7 @@ void HTTPClientActor::init() {
worker_count,
[&] {
return system().spawn<HTTPWorker>(
connection_timeout_, read_timeout_, write_timeout_);
connection_timeout_, read_timeout_, write_timeout_, ssl_verify_);
},
caf::actor_pool::round_robin());

Expand Down
Loading