Merge pull request #1518 from Adyen/tests-unknown-enums

Add unit tests for parsing unexpected fields/enums

Author: gcatanese

.github/workflows/node-ci.yml

@@ -59,8 +59,6 @@ jobs:
             ${{ runner.os }}-node-
       - name: Install dependencies
         run: npm install
-      - name: Run tests
-        run: npm test
       - name: Run tests with coverage
         run: npm run test:coverage
 

src/__mocks__/legalEntityManagement/responses.ts

@@ -193,6 +193,47 @@ export const legalEntity = {
     "type": "individual"
 };
 
+export const legalEntityAdditionalAttributes = {
+    "id": "123456789",
+    "additionalAttribute": "something",
+    "individual": {
+        "email": "string",
+        "name": {
+            "firstName": "string",
+            "infix": "string",
+            "lastName": "string"
+        },
+        "nationality": "string",
+        "phone": {
+            "number": "string",
+            "type": "string"
+        },
+    },
+    "reference": "string",
+    "transferInstruments": [{ "id": "string" }],
+    "type": "individual"
+};
+
+export const legalEntityUnknownEnum = {
+    "id": "123456789",
+    "individual": {
+        "email": "string",
+        "name": {
+            "firstName": "string",
+            "infix": "string",
+            "lastName": "string"
+        },
+        "nationality": "string",
+        "phone": {
+            "number": "string",
+            "type": "string"
+        },
+    },
+    "reference": "string",
+    "transferInstruments": [{ "id": "string" }],
+    "type": "this is unknown"
+};
+
 export const businessLines = {
     "businessLines": [{
         "capability": "receivePayments",

src/__mocks__/terminalApi/sync.ts

@@ -386,3 +386,43 @@ export const syncResEventNotification = {
         }
     }
 };
+
+export const syncResEventNotificationWithAdditionalAttributes = {
+   "SaleToPOIRequest":{
+      "EventNotification":{
+         "EventDetails":"newstate=IDLE&oldstate=START",
+         "EventToNotify":"Shutdown",
+         "TimeStamp":"2019-08-07T10:16:10.000Z",
+         "AdditionalAttribute": "Something"
+      },
+      "MessageHeader":{
+         "SaleID":"POSSystemID12345",
+         "ProtocolVersion":"3.0",
+         "MessageType":"Notification",
+         "POIID":"V400m-324688179",
+         "MessageClass":"Event",
+         "MessageCategory":"Event",
+         "DeviceID":"1517998561",
+         "AdditionalAttribute": "SomethingElse"
+      }
+   }
+};
+
+export const syncResEventNotificationWithUnknownEnum = {
+   "SaleToPOIRequest":{
+      "EventNotification":{
+         "EventDetails":"newstate=IDLE&oldstate=START",
+         "EventToNotify":"this is unknown",
+         "TimeStamp":"2019-08-07T10:16:10.000Z"
+      },
+      "MessageHeader":{
+         "SaleID":"POSSystemID12345",
+         "ProtocolVersion":"3.0",
+         "MessageType":"Notification",
+         "POIID":"V400m-324688179",
+         "MessageClass":"Event",
+         "MessageCategory":"Event",
+         "DeviceID":"1517998561"
+      }
+   }
+};

src/__tests__/checkout.spec.ts

@@ -56,18 +56,6 @@ export function createPaymentsCheckoutRequest(): checkout.PaymentRequest {
     };
 }
 
-// function createPaymentSessionRequest(): checkout.PaymentSetupRequest {
-//     return {
-//         amount: createAmountObject("USD", 1000),
-//         countryCode: "NL",
-//         merchantAccount,
-//         reference,
-//         returnUrl: "https://your-company.com/...",
-//         channel: checkout.PaymentSetupRequest.ChannelEnum.Web,
-//         sdkVersion: "3.7.0"
-//     };
-// }
-
 function createUpdatePaymentLinkRequest(): checkout.UpdatePaymentLinkRequest {
     return {
         "status": checkout.UpdatePaymentLinkRequest.StatusEnum.Expired
@@ -203,20 +191,6 @@ describe("Checkout", (): void => {
             .matchHeader("Idempotency-Key", "testKey");
         await checkoutService.PaymentsApi.paymentsDetails(createPaymentsDetailsRequest(), {idempotencyKey: "testKey"});
 
-        // scope.post("/paymentSession")
-        //     .reply(200, paymentSessionSuccess)
-        //     .matchHeader("Idempotency-Key", "testKey");
-        // const paymentSessionRequest: checkout.PaymentSetupRequest = createPaymentSessionRequest();
-        // await checkoutService.ClassicCheckoutSDKApi.paymentSession(paymentSessionRequest, {idempotencyKey: "testKey"});
-
-        // scope.post("/payments/result")
-        //     .reply(200, paymentsResultSuccess)
-        //     .matchHeader("Idempotency-Key", "testKey");
-        // const paymentResultRequest: checkout.PaymentVerificationRequest = {
-        //     payload: "This is a test payload",
-        // };
-        // await checkoutService.ClassicCheckoutSDKApi.verifyPaymentResult(paymentResultRequest, {idempotencyKey: "testKey"});
-
         const orderRequest: checkout.CreateOrderRequest = {
             amount: createAmountObject("USD", 1000),
             merchantAccount,

src/__tests__/legalEntityManagement.spec.ts

@@ -13,6 +13,8 @@ import {
     businessLines,
     document,
     legalEntity,
+    legalEntityAdditionalAttributes,
+    legalEntityUnknownEnum,
     onboardingLink,
     onboardingTheme,
     onboardingThemes,
@@ -69,6 +71,29 @@ describe("Legal Entity Management", (): void => {
             expect(response.type).toBe("individual");
         });
 
+        it("should support GET /legalEntities/{id} with additional attributes", async (): Promise<void> => {
+            scope.get(`/legalEntities/${id}`)
+                .reply(200, legalEntityAdditionalAttributes);
+
+                await expect(async () => {
+                        const response = await legalEntityManagement.LegalEntitiesApi.getLegalEntity("123456789");
+                        expect(response.id).toBe(id);
+                        expect(response.type).toBe("individual");
+                    }).not.toThrow();
+        });
+
+        it("should support GET /legalEntities/{id} with unknown enum", async (): Promise<void> => {
+            scope.get(`/legalEntities/${id}`)
+                .reply(200, legalEntityUnknownEnum);
+
+                await expect(async () => {
+                        const response = await legalEntityManagement.LegalEntitiesApi.getLegalEntity("123456789");
+                        expect(response.id).toBe(id);
+                        // type is unknown, so it holds whatever value is found in the payload
+                        expect(response.type).toBe("this is unknown");
+                    }).not.toThrow();            
+        });
+
         it("should support PATCH /legalEntities/{id}", async (): Promise<void> => {
             scope.patch(`/legalEntities/${id}`)
                 .reply(200, legalEntity);