Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakes in liveslots tests #11019

Open
siarhei-agoric opened this issue Feb 19, 2025 · 0 comments
Open

Flakes in liveslots tests #11019

siarhei-agoric opened this issue Feb 19, 2025 · 0 comments
Labels
flake flakey test

Comments

@siarhei-agoric
Copy link
Contributor

siarhei-agoric commented Feb 19, 2025 •
edited
Loading

What is the Problem Being Solved?

There are flakes in virtualObjectGC.test.js tests that need to be addressed:
https://github.com/Agoric/agoric-sdk/actions/runs/13403332431/job/37438663845

Description of the Design

Adding some retry logic similar to #11015 would be a good first step.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@siarhei-agoric siarhei-agoric added the flake flakey test label Feb 19, 2025
siarhei-agoric added a commit that referenced this issue Feb 19, 2025
@siarhei-agoric
chore(swingset-liveslots): use avaRetry() in virtualObjectGC.test.js
974047c 
refs: #11019
@siarhei-agoric siarhei-agoric mentioned this issue Feb 19, 2025
Merged
mergify bot pushed a commit that referenced this issue Feb 21, 2025
@siarhei-agoric
chore(swingset-liveslots): use avaRetry() in virtualObjectGC.test.js (#…
7186681 
…11021)

refs: #11019

## Description
Convert test.serial() to avaRetry(test.serial, ...) in virtualObjectGC.test.js

### Security Considerations
N/A

### Scaling Considerations
N/A

### Documentation Considerations
N/A

### Testing Considerations
Ran virtualObjectGC.test.js tests manually, all pass.

### Upgrade Considerations
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flake flakey test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siarhei-agoric