Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startLife tests don't silence dead incarnation's unhandled promise rejections #11027

Open
michaelfig opened this issue Feb 20, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request liveslots requires vat-upgrade to deploy changes needs-design

Comments

@michaelfig
Copy link
Member

What is the Problem Being Solved?

In #10686

test.serial(
  expectUnhandled(2),
  'vow rejected with storable reason, upgraded, then handled',
          I suppose that the 2 unhandled rejections are an artifact of the test infra, and in real life we'd only expect 1 (the after upgrade one)? The promise created by the unhandled rejection tracker in the first incarnation will actually get GCed after starting a new life and get reported, where in a real vat, the first incarnation would be gone, and not report anything.

Originally posted by @mhofman in #10686 (comment)

Description of the Design

@mhofman asks: can we somehow silence this case in tests here (and in watch)? Maybe an integration of fake liveslots with the unhandled rejection tracker.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@michaelfig michaelfig added enhancement New feature or request liveslots requires vat-upgrade to deploy changes needs-design labels Feb 20, 2025
@michaelfig michaelfig changed the title startLife tests don't silence unhandled rejections startLife tests don't silence dead incarnation's unhandled promise rejections Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request liveslots requires vat-upgrade to deploy changes needs-design
Projects
None yet
Development

No branches or pull requests

2 participants