Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make CI / Github lint happy #11034

Open
siarhei-agoric opened this issue Feb 21, 2025 · 0 comments · Fixed by #11036
Open

chore: make CI / Github lint happy #11034

siarhei-agoric opened this issue Feb 21, 2025 · 0 comments · Fixed by #11036
Assignees
@siarhei-agoric
Labels
code-style defensive correctness patterns; readability thru consistency

Comments

@siarhei-agoric
Copy link
Contributor

siarhei-agoric commented Feb 21, 2025 •
edited
Loading

What is the Problem Being Solved?

Github lint complaints:

Check failure on line 252 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions/ golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)


Check failure on line 443 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)

Check failure on line 17 in golang/cosmos/x/vtransfer/handler.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrap is deprecated: functionality of this package has been moved to it's own module: (staticcheck)

Check warning on line 155 in a3p-integration/proposals/n:upgrade-next/test/agoricNames.test.js
GitHub Actions / lint-rest
Prefer for...of instead of Array.forEach

Check warning on line 16 in packages/network/test/fakes.js
GitHub Actions / lint-primary
Unexpected constant condition

Check warning on line 128 in packages/ERTP/test/unitTests/mintObj.test.js
GitHub Actions / lint-primary
Expected JSDoc block to be aligned

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Run lint.

Upgrade Considerations
@siarhei-agoric siarhei-agoric added the enhancement New feature or request label Feb 21, 2025
@siarhei-agoric siarhei-agoric self-assigned this Feb 21, 2025
@siarhei-agoric siarhei-agoric added code-style defensive correctness patterns; readability thru consistency and removed enhancement New feature or request labels Feb 21, 2025
siarhei-agoric added a commit that referenced this issue Feb 21, 2025
@siarhei-agoric
chore: fix lint in golang, a3p, network, ERTP
2f92997 
refs: #11034
@siarhei-agoric siarhei-agoric mentioned this issue Feb 21, 2025
Merged
siarhei-agoric added a commit that referenced this issue Feb 24, 2025
@siarhei-agoric
chore: fix lint in golang, a3p, network, ERTP
7d92b5a 
refs: #11034
siarhei-agoric added a commit that referenced this issue Feb 25, 2025
@siarhei-agoric
chore(a3p-integration): fix lint
3abad27 
refs: #11034
siarhei-agoric added a commit that referenced this issue Feb 25, 2025
@siarhei-agoric
chore: fix lint in golang, a3p, network, ERTP
da099b3 
refs: #11034
siarhei-agoric added a commit that referenced this issue Feb 25, 2025
@siarhei-agoric
chore(a3p-integration): fix lint
0a8497f 
refs: #11034
mergify bot pushed a commit that referenced this issue Feb 25, 2025
@siarhei-agoric
chore: fix lint in golang, a3p, network, ERTP (#11036)
6ef8304 
refs: #11034 

## Description

Github lint complaints:
```
Check failure on line 252 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions/ golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)

```
```
Check failure on line 443 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)
```
```
Check failure on line 17 in golang/cosmos/x/vtransfer/handler.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrap is deprecated: functionality of this package has been moved to it's own module: (staticcheck)
```
```
Check warning on line 155 in a3p-integration/proposals/n:upgrade-next/test/agoricNames.test.js
GitHub Actions / lint-rest
Prefer for...of instead of Array.forEach
```
```
Check warning on line 16 in packages/network/test/fakes.js
GitHub Actions / lint-primary
Unexpected constant condition
```
```
Check warning on line 128 in packages/ERTP/test/unitTests/mintObj.test.js
GitHub Actions / lint-primary
Expected JSDoc block to be aligned
```
## Description of the Design

## Security Considerations

## Scaling Considerations

## Test Plan
Run lint.

## Upgrade Considerations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siarhei-agoric siarhei-agoric

Labels
code-style defensive correctness patterns; readability thru consistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix lint in golang, a3p, network, ERTP Agoric/agoric-sdk
1 participant
@siarhei-agoric