Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint in golang, a3p, network, ERTP #11036

Merged
merged 2 commits into from
Feb 25, 2025
Merged

chore: fix lint in golang, a3p, network, ERTP #11036

merged 2 commits into from
Feb 25, 2025

Conversation

siarhei-agoric
Copy link
Contributor

@siarhei-agoric siarhei-agoric commented Feb 21, 2025 •
edited
Loading

closes: #11034

Description

Github lint complaints:

Check failure on line 252 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions/ golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)


Check failure on line 443 in golang/cosmos/x/vtransfer/keeper/keeper.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrapf is deprecated: functionality of this package has been moved to it's own module: (staticcheck)

Check failure on line 17 in golang/cosmos/x/vtransfer/handler.go
GitHub Actions / golangci-lint (no-failure)
SA1019: sdkerrors.Wrap is deprecated: functionality of this package has been moved to it's own module: (staticcheck)

Check warning on line 155 in a3p-integration/proposals/n:upgrade-next/test/agoricNames.test.js
GitHub Actions / lint-rest
Prefer for...of instead of Array.forEach

Check warning on line 16 in packages/network/test/fakes.js
GitHub Actions / lint-primary
Unexpected constant condition

Check warning on line 128 in packages/ERTP/test/unitTests/mintObj.test.js
GitHub Actions / lint-primary
Expected JSDoc block to be aligned

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Run lint.

Upgrade Considerations

@siarhei-agoric siarhei-agoric added the code-style defensive correctness patterns; readability thru consistency label Feb 21, 2025
@siarhei-agoric siarhei-agoric requested a review from a team as a code owner February 21, 2025 22:00
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 21, 2025 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a8497f
Status: ✅  Deploy successful!
Preview URL: https://1db6c8e8.agoric-sdk.pages.dev
Branch Preview URL: https://sliakh-11034-make-lint-happy.agoric-sdk.pages.dev

View logs

gibson042
gibson042 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We should probably suppress the «test.todo() should not be used» in a3p-integration/proposals/z:acceptance/test/initial.test.js as well, just to eliminate that last bit of noise.

@siarhei-agoric siarhei-agoric force-pushed the sliakh-11034-make-lint-happy branch from 20a8586 to 7d92b5a Compare February 24, 2025 13:20
@siarhei-agoric
Copy link
Contributor Author

Nice! We should probably suppress the «test.todo() should not be used» in a3p-integration/proposals/z:acceptance/test/initial.test.js as well, just to eliminate that last bit of noise.

Is that our standard procedure?
If yes, then we should just disable the rule itself.

$ grep -riIn test.todo * | grep -v '\.md'
a3p-integration/proposals/z:acceptance/test/initial.test.js:3:test.todo('initial test');
multichain-testing/test/deposit-withdraw-lca.test.ts:150:test.todo('Deposit and Withdraw ATOM/OSMO to localOrchAccount via offer #9966');
multichain-testing/test/fast-usdc/fast-usdc.test.ts:809:test.todo('mint while Advancing; still Disbursed');
packages/vat-data/test/durable-classes.test.js:147:test.todo('Add tests for durability');
packages/vat-data/test/prepare.test.js:132:test.todo('Demonstrate that the baggage can be used to revive objects.');
packages/xsnap/src/avaAssertXS.js:357:test.todo = _title => {};
packages/smart-wallet/test/walletFactory.test.js:216:test.todo(
packages/orchestration/test/facade-durability.test.ts:268:test.todo('contract upgrade');
packages/orchestration/test/staking-ops.test.ts:554:test.todo('undelegate is cancellable - cosmos cancelUnbonding');
packages/orchestration/test/examples/stake-ica.contract.test.ts:172:test.todo('undelegate multiple delegations');
packages/boot/test/bootstrapTests/vaults-upgrade.test.ts:610:test.todo('governance changes maintained after restart');
packages/boot/test/bootstrapTests/demo-config.test.ts:110:test.todo('demo config bootstrap succeeds');
packages/boot/test/bootstrapTests/orchestration.test.ts:283:test.todo('undelegate wallet offer');
packages/boot/test/bootstrapTests/orchestration.test.ts:284:test.todo('undelegate with multiple undelegations wallet offer');
packages/boot/test/bootstrapTests/orchestration.test.ts:285:test.todo('redelegate wallet offer');
packages/boot/test/bootstrapTests/orchestration.test.ts:286:test.todo('withdraw reward wallet offer');
packages/inter-protocol/test/smartWallet/psm-integration.test.js:528:test.todo('bad offer schema');
packages/inter-protocol/test/smartWallet/psm-integration.test.js:529:test.todo('not enough funds');
packages/inter-protocol/test/smartWallet/psm-integration.test.js:530:test.todo(
packages/zoe/test/unitTests/contracts/loan/addCollateral.test.js:17:test.todo('makeAddCollateralInvitation - test bad proposal');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:21:test.todo('loan - no mmr');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:22:test.todo('loan - bad mmr');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:23:test.todo('loan - no priceAuthority');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:24:test.todo('loan - badPriceAuthority');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:25:test.todo('loan - bad autoswap, no autoswap');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:26:test.todo('loan - wrong keywords');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:28:test.todo('loan - lend - wrong exit rule');
packages/zoe/test/unitTests/contracts/loan/loan-e2e.test.js:29:test.todo('loan - lend - must want nothing');
packages/zoe/test/unitTests/contracts/loan/borrow.test.js:549:test.todo('borrow bad proposal');
packages/zoe/test/unitTests/contracts/loan/borrow.test.js:551:test.todo('schedule a liquidation that fails, giving collateral to the lender');
packages/zoe/test/unitTests/contracts/loan/close.test.js:17:test.todo('makeCloseLoanInvitation repay partial fails');
packages/zoe/test/unitTests/contracts/loan/close.test.js:18:test.todo(`makeCloseLoanInvitation repay but don't repay interest`);
packages/zoe/test/unitTests/contracts/loan/close.test.js:19:test.todo(`repay but wrong proposal type`);
packages/zoe/test/unitTests/contracts/loan/close.test.js:20:test.todo(`repay - request too much collateral`);
packages/zoe/test/unitTests/zoe.test.js:337:test.todo(`zcf.registerFeeMint twice in different contracts`);
packages/fast-usdc/test/exos/settler.test.ts:743:test.todo('creator facet methods');
packages/fast-usdc/test/exos/settler.test.ts:745:test.todo('ignored packets');
packages/fast-usdc/test/exos/status-manager.test.ts:389:test.todo('ADVANCE_FAILED -> FORWARDED transition');
packages/fast-usdc/test/fast-usdc.contract.test.ts:711:test.todo(
packages/fast-usdc/test/fast-usdc.contract.test.ts:727:test.todo('document metrics storage schema');
packages/fast-usdc/test/fast-usdc.contract.test.ts:728:test.todo('get metrics from vstorage');
packages/fast-usdc/test/fast-usdc.contract.test.ts:925:test.todo('C18 - forward - MUST log and alert these incidents');
packages/fast-usdc/test/fast-usdc.contract.test.ts:1068:test.todo(

@siarhei-agoric siarhei-agoric force-pushed the sliakh-11034-make-lint-happy branch from 3abad27 to 0a8497f Compare February 25, 2025 15:12
@siarhei-agoric
Copy link
Contributor Author

Nice! We should probably suppress the «test.todo() should not be used» in a3p-integration/proposals/z:acceptance/test/initial.test.js as well, just to eliminate that last bit of noise.

Done.

@siarhei-agoric siarhei-agoric added the automerge:squash Automatically squash merge label Feb 25, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 25, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 25, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 6ef8304 into master Feb 25, 2025
94 checks passed
@mergify mergify bot deleted the sliakh-11034-make-lint-happy branch February 25, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 approved these changes

@mhofman mhofman Awaiting requested review from mhofman

Assignees
No one assigned
Labels
automerge:squash Automatically squash merge code-style defensive correctness patterns; readability thru consistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: make CI / Github lint happy
2 participants
@siarhei-agoric @gibson042