Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit "any" type in package exports #11038

Open
turadg opened this issue Feb 21, 2025 · 0 comments
Open

implicit "any" type in package exports #11038

turadg opened this issue Feb 21, 2025 · 0 comments
Labels
bug Something isn't working devex developer experience technical-debt

Comments

@turadg
Copy link
Member

turadg commented Feb 21, 2025

Describe the bug

node_modules/@agoric/fast-usdc/src/types.ts:10:48 - error TS7016: Could not find a declaration file for module './constants.js'. '/opt/agoric/agoric-subql/node_modules/@agoric/fast-usdc/src/constants.js' implicitly has an 'any' type.

10 import type { PendingTxStatus, TxStatus } from './constants.js';
                                                  ~~~~~~~~~~~~~~~~

node_modules/@agoric/fast-usdc/src/types.ts:11:36 - error TS7016: Could not find a declaration file for module './fast-usdc.contract.js'. '/opt/agoric/agoric-subql/node_modules/@agoric/fast-usdc/src/fast-usdc.contract.js' implicitly has an 'any' type.

11 import type { FastUsdcTerms } from './fast-usdc.contract.js';
                                      ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@agoric/fast-usdc/src/types.ts:12:37 - error TS7016: Could not find a declaration file for module './exos/liquidity-pool.js'. '/opt/agoric/agoric-subql/node_modules/@agoric/fast-usdc/src/exos/liquidity-pool.js' implicitly has an 'any' type.

12 import type { RepayAmountKWR } from './exos/liquidity-pool.js';
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@agoric/fast-usdc/src/types.ts:149:20 - error TS7016: Could not find a declaration file for module './constants.js'. '/opt/agoric/agoric-subql/node_modules/@agoric/fast-usdc/src/constants.js' implicitly has an 'any' type.

149 export type * from './constants.js';
                       ~~~~~~~~~~~~~~~~

node_modules/@agoric/fast-usdc/src/types.ts:150:39 - error TS7016: Could not find a declaration file for module './exos/liquidity-pool.js'. '/opt/agoric/agoric-subql/node_modules/@agoric/fast-usdc/src/exos/liquidity-pool.js' implicitly has an 'any' type.

150 export type { LiquidityPoolKit } from './exos/liquidity-pool.js';
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@agoric/orchestration/src/orchestration-api.ts:8:32 - error TS7016: Could not find a declaration file for module '@agoric/time'. '/opt/agoric/agoric-subql/node_modules/@agoric/time/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/agoric__time` if it exists or add a new declaration (.d.ts) file containing `declare module '@agoric/time';`

8 import type { Timestamp } from '@agoric/time';

To Reproduce

In https://github.com/Agoric/agoric-subql/ remove "noImplicityAny: false" and run tsc.

Expected behavior

Typed exports

Agoric CI catches deps that have implicit any

@turadg turadg added bug Something isn't working devex developer experience technical-debt labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devex developer experience technical-debt
Projects
None yet
Development

No branches or pull requests

1 participant