chore(settler): narrow "unexpected channel" log #11046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `receiveUpcall` fires on incoming and outgoing ibc transfers. quiet the "unexpected channel" log on outgoing transfers sent by the contract
dckc
reviewed
Feb 24, 2025
| @@ -97,6 +97,7 @@ export const stateShape = harden({ | |||
| settlementAccount: M.remotable('Account'), | |||
| registration: M.or(M.undefined(), M.remotable('Registration')), | |||
| sourceChannel: M.string(), | |||
| destChannel: M.string(), | |||
There was a problem hiding this comment.
hm. state shape change.
I suppose this is OK because we're making a new settler next time.
Please elaborate the upgrade considerations to be explicit about this.
| @@ -160,6 +161,7 @@ export const prepareSettler = ( | |||
| /** | |||
| * @param {{ | |||
| * sourceChannel: IBCChannelID; | |||
| * destChannel: IBCChannelID; | |||
There was a problem hiding this comment.
This (and the fact that tests had to change) looks like a breaking change to the makeSettler API.
Again, I think it's fine because we're making a new settler, but please be explicit in the upgrade considerations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11047
Description
receiveUpcallfires on incoming and outgoing ibc transfers. This change quiets the "unexpected channel" log on outgoing transfers sent by the contract'ssettlementAccount. (ThesettlementAccountwill send an outgoing transfer during theForwardsequence.)Security Considerations
None, diagnostic-only change.
Scaling Considerations
Less noise in SwingSet logs
Documentation Considerations
None
Testing Considerations
None
Upgrade Considerations
This is a breaking change for
SettlerKit/makeSettler, via the addition of a new state property instateandstateShape.