Skip to content

Commit f512584

Browse files
authored
Merge pull request #4 from lucasmpr/master
Fixes wrong error verification and bumps version number to 1.1.1
2 parents e9b6582 + 5b34593 commit f512584

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### 1.1.1 2019-10-07
2+
3+
- Fixes wrong error verification that caused no exceptions to ever be thrown
4+
15
### 1.0.0 2017-11-18
26

37
- Add .Net Standard 2.0 Support

OneSignal.RestAPIv3.Client/OneSignal.RestAPIv3.Client.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
66
<IncludeSymbols>true</IncludeSymbols>
77
<IncludeSource>true</IncludeSource>
8-
<Version>1.1.0</Version>
8+
<Version>1.1.1</Version>
99
<PackageIconUrl>https://raw.githubusercontent.com/Alegrowin/OneSignal.RestAPIv3.Client/master/OneSignal.RestAPIv3.Client/onesignal_large_icon_default.png</PackageIconUrl>
1010
<PackageProjectUrl>https://github.com/Alegrowin/OneSignal.RestAPIv3.Client</PackageProjectUrl>
1111
<PackageLicenseUrl>https://github.com/Alegrowin/OneSignal.RestAPIv3.Client/blob/master/LICENSE</PackageLicenseUrl>
@@ -14,7 +14,7 @@
1414
Feel Free to contribute! :)</Description>
1515
<RepositoryUrl>https://github.com/Alegrowin/OneSignal.RestAPIv3.Client</RepositoryUrl>
1616
<PackageTags>OneSignal .NetStandard2.0 .NetCore2.0 .NetFramework452 net452 netstandard2.0 netcoreapp2.0 Client MultiFramework</PackageTags>
17-
<PackageReleaseNotes>Now targets multi Frameworks. (.Net Standard 2.0 and .Net Framewok 4.5.2)
17+
<PackageReleaseNotes>Fixes the exception throwing mechanism
1818
</PackageReleaseNotes>
1919
<ApplicationIcon />
2020
<Win32Resource />

OneSignal.RestAPIv3.Client/Resources/Notifications/NotificationsResource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public async Task<NotificationCancelResult> CancelAsync(NotificationCancelOption
105105
}
106106

107107
private T GetResponseData<T>(IRestResponse<T> restResponse) {
108-
if (!(restResponse.StatusCode != HttpStatusCode.Created || restResponse.StatusCode != HttpStatusCode.OK))
108+
if (restResponse.StatusCode != HttpStatusCode.Created && restResponse.StatusCode != HttpStatusCode.OK)
109109
{
110110
ThrowIfError(restResponse);
111111
}

0 commit comments

Comments
 (0)