wrong-type-argument listp error on NixOS when running treemacs-find-ignored-files.py

[ghostlou1043]

Description

On NixOS, Treemacs throws a Lisp error when running
treemacs-find-ignored-files.py.

It seems Treemacs assumes a list where a string path is returned,
causing a wrong-type-argument listp error.

Error

Debugger entered--Lisp error: (wrong-type-argument listp /nix/store/rlq03x4cwf8zn73hxaxnx0zn5q9kifls-bash-5.3p3/bin/sh:)
  cdr(/nix/store/rlq03x4cwf8zn73hxaxnx0zn5q9kifls-bash-5.3p3/bin/sh:)
  #f(compiled-function (process status) ...)
  (#<process Pfuture-Callback
    (/etc/profiles/per-user/lou/bin/python3 -O
     ~/.config/emacs/straight/build/treemacs/treemacs-find-ignored-files.py
     git ~/.config/emacs)>
   "finished\n")

[jmsgrogan]

This seems like a regression from this commit: 2dd6d86 @L3n41c

The git command is altogether failing on system like Nix and for me Guix which rely on propagating environment settings from the calling process. Undoing that commit fixes it.

It seems like the original PR should have appended to the existing environment rather then creating a clean ENV from scratch. The default Popen behavior is to inherit the environment if the env arg is none: https://docs.python.org/3/library/subprocess.html#subprocess.Popen

I imagine the PR may have broken a few other functions on these platforms.

[ghostlou1043]

Thank you for your help, I pulled the latest merge, and now the error is:
Open dired with C-x d

Debugger entered--Lisp error: (wrong-type-argument listp warning:)
  cdr(warning:)
#f(compiled-function (process status) #<bytecode -0x129c52dd8fc669e6>)
(#<process  Pfuture-Callback
            (/etc/profiles/per-user/lou/bin/python3 -O
                                                    /home/lou/.config/emacs/straight/build/treemacs/treemacs-find-ignored-files.py
                                                    git /home/lou/.config/emacs)>
                                                    "finished\n")

M-x treemacs

Debugger entered--Lisp error: (wrong-type-argument listp warning:)
  cdr(warning:)
#f(compiled-function (process status) #<bytecode 0x1dd54a182d48960b>)
(#<process  Pfuture-Callback (/etc/profiles/per-user/lou/bin/python3 -O
                                                                     /home/lou/.config/emacs/straight/build/treemacs/treemacs-find-ignored-files.py git
                                                                     /home/lou/.config/emacs)>
                                                                     "finished\n")
  sit-for(2)
  #f(compiled-function () #<bytecode -0xc5c194212f83685>)()
  apply(#f(compiled-function () #<bytecode -0xc5c194212f83685>) nil)
  timer-event-handler([t 26960 51357 510311 nil #f(compiled-function () #<bytecode -0xc5c194212f83685>) nil nil 77000 nil])

The content inside the cdr parentheses has changed compared to before.
I think I should provide more detailed error information. What should I do?

[jmsgrogan]

I can't reproduce it with my system (Guix) since the linked PR fixes it for me now - but you can run the Python script with shown args from the error /home/lou/.config/emacs/straight/build/treemacs/treemacs-find-ignored-files.py git /home/lou/.config/emacs just in a shell by itself and see what it returns - that's the original troubleshooting I did. It might give a hint via the shell output and you can modify the Python script to troubleshoot more if you do see an error.

I'm not really familiar with Emacs Lisp so not sure why the 'cdr' content is different now.

[Alexander-Miller]

#1173 should have fixed this and was merged recently.

If it didn't then let's debug starting from just the python parts. You can run the script like this

python src/scripts/treemacs-find-ignored-files.py /usr/bin/git /home/am/Documents/git/treemacs

First arg is the git binary, following args are git roots to look at.

Output should be a list of pairs, first a parent directory, then the file that is ignored, without spaces.

("/home/am/Documents/git/treemacs""/home/am/Documents/git/treemacs/Extensions.el")