perf(label): skip redundant markup updates#5111
Open
SaveTheRbtz wants to merge 1 commit into
Open
Conversation
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALabelhelpers that skip identical label and tooltip markup writes.sway/windowandmpdlabel paths.Why this was needed
baseline.perf.datahad visible GTK/UI update work. The GTK layout/draw-ish path accounted for about 213M cycles, which is avoidable when a module writes identical markup repeatedly.Change
Cache the last label and tooltip markup in
ALabel. SkipGtk::Label::set_markup()andset_tooltip_markup()when the new markup is unchanged.Effect in comparison
GTK layout/draw-ish work drops from 213M to 17M cycles, indicating fewer no-op relayout/redraw paths.
Testing
ninja -C buildmeson test -C build