Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move signing action back to SigningUserAction and implement SigningUserActionTests again after new IAuthenticationContext #1061

Open
cammiida opened this issue Jan 23, 2025 · 0 comments · Fixed by #1172
Open

Move signing action back to SigningUserAction and implement SigningUserActionTests again after new IAuthenticationContext #1061

cammiida opened this issue Jan 23, 2025 · 0 comments · Fixed by #1172
Assignees
@cammiida
Labels
kind/chore
Milestone
Signering MVP

Comments

@cammiida
Copy link
Contributor

cammiida commented Jan 23, 2025 •
edited
Loading

Background:

Commented out tests for now because they depend on UserHelper which will be obsolete when IAuthenticationContext is out and makes mocking difficult.

Reimplement when IAuthenticationContext is out.
@cammiida cammiida converted this from a draft issue Jan 23, 2025
@cammiida cammiida moved this to 📈 Todo in Team Apps Feb 26, 2025
@cammiida cammiida added this to the Signering MVP milestone Mar 10, 2025
@cammiida cammiida self-assigned this Mar 10, 2025
@cammiida cammiida moved this from 📈 Todo to 👷 In Progress in Team Apps Mar 10, 2025
@cammiida cammiida linked a pull request Mar 10, 2025 that will close this issue
moves sign action back to SigningUserAction and reimplement tests #1172
Merged
5 tasks
@cammiida cammiida moved this from 👷 In Progress to 🔎 Review in Team Apps Mar 10, 2025
@cammiida cammiida changed the title Implement SigningUserActionTests again after new IAuthenticationContext Move signing action back to SigningUserAction and implement SigningUserActionTests again after new IAuthenticationContext Mar 10, 2025
@cammiida cammiida moved this from 🔎 Review to ✅ Done in Team Apps Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cammiida cammiida

Labels
kind/chore
Projects
Team Apps
Status: ✅ Done
Milestone
Signering MVP
Development

Successfully merging a pull request may close this issue.

moves sign action back to SigningUserAction and reimplement tests Altinn/app-lib-dotnet
1 participant
@cammiida