Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation does not run on process/next in v8 #470

Closed
ivarne opened this issue Mar 1, 2024 · 1 comment · Fixed by #472
Closed

Validation does not run on process/next in v8 #470

ivarne opened this issue Mar 1, 2024 · 1 comment · Fixed by #472
Assignees
@ivarne
Labels
area/validation Custom validations/validation messages kind/bug Something isn't working
Milestone
8.0.0

Comments

@ivarne
Copy link
Member

ivarne commented Mar 1, 2024

Description of the bug

Reported on slack

Steps To Reproduce

Hei 🙂
Jeg tester ut v8 og får ikke valideringen til å fungere ved process/next, mellom task_1 og task_2 som jeg er vant til fra v7.
Eks. Jeg har lagt til en dataType i applicationMetadata og satt MinCount: 1 og taskId: "Task_1". Når jeg går videre til task_2 med process/next så hadde jeg forventet at den ikke skulle gå videre til task_2, dersom datatypen med MinCount: 1 inne var lastet opp i Task_1
Er dette en feil, eller kommer det noe nytt i v8 rundt validering av task ved process next?
Det ser ut som dere gjør validering i completeProcess, men ikke mollom hver task.

Additional Information

No response
@ivarne ivarne added kind/bug Something isn't working status/triage labels Mar 1, 2024
@ivarne ivarne added this to Team Apps Mar 1, 2024
@ivarne ivarne moved this to 👷 In Progress in Team Apps Mar 1, 2024
@ivarne ivarne added area/validation Custom validations/validation messages and removed status/triage labels Mar 1, 2024
@ivarne ivarne added this to the 8.0.0 milestone Mar 1, 2024
@ivarne
Copy link
Member Author

ivarne commented Mar 1, 2024

Root cause seems to be the removal of src/Altinn.App.Core/Internal/Process/ProcessChangeHandler.cs in #237 @tjololo

@ivarne ivarne mentioned this issue Mar 1, 2024
Merged
5 tasks
@HanneLauritsen1967 HanneLauritsen1967 moved this from 👷 In Progress to 🔎 Review in Team Apps Mar 5, 2024
@tjololo tjololo linked a pull request Mar 11, 2024 that will close this issue
Add back validation on process/next #472
Merged
5 tasks
@RonnyB71 RonnyB71 moved this from 🔎 Review to ✅ Done in Team Apps Mar 11, 2024
@ivarne ivarne closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivarne ivarne

Labels
area/validation Custom validations/validation messages kind/bug Something isn't working
Projects
Team Apps
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Add back validation on process/next Altinn/app-lib-dotnet
1 participant
@ivarne