Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type visibility and access (attachments vs signatures vs internal state) #981

Open
5 tasks
bjorntore opened this issue Dec 16, 2024 · 0 comments
Open
5 tasks
Assignees

Comments

@bjorntore
Copy link
Contributor

bjorntore commented Dec 16, 2024

We have identified three levels of data types:

  • Attachments that are relevant to the end user and that are shown in the attachment list in the GUI.
  • Signatures, payment information and other data types that TE will care about, but that there is no point in displaying in the attachment list.
  • Internal state that only the app needs to see and know about. Like the state about the signees.

Find a good solution to this. Probably using some property on the data type. Must not be a breaking change.

Edit:
Setting "app:owned" as allowedContributers solves the most important thing: That the apps internal state objects can't be edited. What remains then is visibility. #1045 solves most of that.

Acceptance criteria:

  • Can hide signatures and payment information from the attachments list.
  • Can hide the signee state object from the attachment list.
  • Normal attachments show up as before.
  • Not a breaking change. Existing apps work 100% as before. The config is opt in.
  • Tasks for Studio team have been created, to configure relevant data types with this automatically.
@bjorntore bjorntore self-assigned this Dec 16, 2024
@bjorntore bjorntore converted this from a draft issue Dec 16, 2024
@bjorntore bjorntore added this to the Signering MVP milestone Dec 16, 2024
@bjorntore bjorntore moved this from 📈 Todo to 👷 In Progress in Team Apps Jan 2, 2025
@bjorntore bjorntore moved this from 👷 In Progress to 📈 Todo in Team Apps Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📈 Todo
Development

No branches or pull requests

2 participants