fixes negative time to completion values

Author: redreceipt

linear/client.py

@@ -11,29 +11,40 @@
 
 def _compute_assignee_time_to_fix(issue, assignee_name):
     """Return days between last assignment to `assignee_name` and completion."""
-    history = issue.get("history", {}).get("edges", [])
-    last_assigned = None
-    for edge in history:
-        node = edge.get("node", {})
-        to_assignee = node.get("toAssignee")
-        if not to_assignee:
-            continue
-        if to_assignee.get("displayName") == assignee_name:
-            updated = node.get("updatedAt")
-            if updated and (last_assigned is None or updated > last_assigned):
-                last_assigned = updated
-    if not last_assigned:
-        return None
     completed_at = issue.get("completedAt")
     if not completed_at:
         return None
     try:
         completed_dt = datetime.strptime(completed_at, "%Y-%m-%dT%H:%M:%S.%fZ")
-        assigned_dt = datetime.strptime(last_assigned, "%Y-%m-%dT%H:%M:%S.%fZ")
-        return (completed_dt - assigned_dt).days
     except ValueError:
         return None
 
+    history = issue.get("history", {}).get("edges", [])
+    last_assigned = None
+    for edge in history:
+        node = edge.get("node", {})
+        to_assignee = node.get("toAssignee")
+        if not to_assignee or to_assignee.get("displayName") != assignee_name:
+            continue
+        updated = node.get("updatedAt")
+        if not updated:
+            continue
+        try:
+            updated_dt = datetime.strptime(updated, "%Y-%m-%dT%H:%M:%S.%fZ")
+        except ValueError:
+            continue
+        if updated_dt > completed_dt:
+            # Ignore assignment changes that happened after the issue was closed.
+            continue
+        if last_assigned is None or updated_dt > last_assigned:
+            last_assigned = updated_dt
+
+    if last_assigned is None:
+        return None
+
+    delta_days = (completed_dt - last_assigned).days
+    return max(delta_days, 0)
+
 
 _thread_local = threading.local()