Add interactive launch mode. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WhatAmISupposedToPutHere Judging from the commit history, does this PR depend on #47? That's still in draft status anyway. |
|
Technically yes, but i am not super sure why that one is marked as draft. |
alyssarosenzweig
force-pushed
the
interactive
branch
from
b84e835
to
f7717a5
Compare
alyssarosenzweig
requested review from
alyssarosenzweig and
asahilina
as code owners
alyssarosenzweig
force-pushed
the
interactive
branch
from
f7717a5
to
e1feb6b
Compare
Unconditionally forward a range of ports to sockets named `$XDG_RUNTIME_DIR/krun/socket/port-$PORT`. This allows applications to dynamically bind to sockets at those paths and have them forwarded to the guest as vsock ports, after the krun VM is already running. The port range is currently hardcoded as 50000..50200. Signed-off-by: Asahi Lina <[email protected]> Signed-off-by: Sasha Finkelstein <[email protected]>
After launching a process via the server, krun immediately closes and the
launched process' std{in,out,err} go nowhere. Add a --interactive flag that
allocates a pseudo-terminal, routes it to the host and connects to it.
Somewhat like '-it' in docker/podman exec.
Signed-off-by: Sasha Finkelstein <[email protected]>
WhatAmISupposedToPutHere
force-pushed
the
interactive
branch
from
e1feb6b
to
98f542b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After launching a process via the server, krun immediately closes and the
launched process' std{in,out,err} go nowhere. Add a --interactive flag that
allocates a pseudo-terminal, routes it to the host and connects to it.
Somewhat like '-it' in docker/podman exec.