Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer to peer code review #2

Open
IamYunusAli opened this issue Jun 24, 2022 · 4 comments
Open

peer to peer code review #2

IamYunusAli opened this issue Jun 24, 2022 · 4 comments

Comments

@IamYunusAli
Copy link

IamYunusAli commented Jun 24, 2022

Great job on achieving these so far, here are comments I have seen an issue on

  • The Headline carousel section has a text-overflow problem kindly fix that.
  • The hamburger menu on the nav bar should change to the original hamburger icon after a list selection.
  • kindly fix the text-overflow on the About page - Previous events section (use flex or reduce the fonts to match the sizes of your container)

Keep coding, keep changing the world

@AsimKhan2019
Copy link
Owner

@IamYunusAli Thank you for the review, I will surely look into them and fix the remaining problems. I will use flex and reduce font sizes in my pages.

@ademibowale
Copy link

  • Nice job and hardworking ,kindly fix the hambrger menu on the nav bar and fix the overflow text on the about section.

@AsimKhan2019
Copy link
Owner

@ademibowale Thank you, yes I will look into these smaller issues that were not appearing yesterday. I will reduce the text font sizes and fix the overflow issue.

@AsimKhan2019
Copy link
Owner

AsimKhan2019 commented Jun 24, 2022

Hello Team,

I made some adjustments to the pages, kindly please check and let me know if this is ok.

Regards,

Asim Khan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants