Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisBroadcaster connect always to localhost #192

Open
christianHennig opened this issue Jul 13, 2015 · 4 comments
Open

RedisBroadcaster connect always to localhost #192

christianHennig opened this issue Jul 13, 2015 · 4 comments

Comments

@christianHennig
Copy link

I use the RedisBroadCaster:
getBroadcasterConfig().addFilter( new RedisFilter( URI.create( "http://x.x.x.x:6379" ) ) );

The Ip will ignored and overwriten with localhost:
https://github.com/Atmosphere/atmosphere-extensions/blob/master/redis/modules/src/main/java/org/atmosphere/plugin/redis/RedisBroadcaster.java#L42

@jfarcand
Copy link
Member

Good catch! Can you do me a favor and do a pull request? I will cut an official release in return.

@christianHennig
Copy link
Author

Good point. I will do a pull request the next days.

@yissachar
Copy link

Can't this be configured through the servlet config? See https://github.com/Atmosphere/atmosphere-extensions/blob/master/redis/modules/src/main/java/org/atmosphere/plugin/redis/RedisUtil.java#L69

I am setting org.atmosphere.plugin.redis.RedisBroadcaster.server to http://myredisserver:6379 and it seems to work for me.

Still it is weird to pass in a URI when that URI is either overridden to localhost or pulled from the servlet config, so the code can probably be cleaned up.

@Flo354
Copy link

Flo354 commented Jul 24, 2016

Any news on this issue ? I will copy the source meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants