Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long-polling calls onMessagePublished in case of error #13

Open
xdenser opened this issue Nov 23, 2018 · 0 comments
Open

long-polling calls onMessagePublished in case of error #13

xdenser opened this issue Nov 23, 2018 · 0 comments

Comments

@xdenser
Copy link

xdenser commented Nov 23, 2018

this is strange
normally after call to
socket.push(data)
i do not get onMessagePublished
but if an error occurs during send in XMLHTTPRequest
then onMessagePublished is called and request object contains status "Ok"
error is in response body
actually nothing indicates clearly that there was some error
I would expect that the library either will retry to send the message or will call onError handler

to simulate just fail some of the requests in
XMLHTTPRequest.js
around
request = doRequest(options, responseHandler).on("error", errorHandler);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant