Updated liniting rules

Author: cojennin

modules/dist/notifications.build.js

@@ -39,11 +39,6 @@
 	font-size: 12px;
 }
 
-.ef-post_following_list li .ef-user-subscribe-actions {
-	float: right;
-	margin-top: 5px;
-}
-
 .ef-post_following_list li .ef-user-list-badges {
 	margin-top: 10px;
 }

modules/notifications/lib/notifications.css

@@ -76,19 +76,18 @@ jQuery( document ).ready( function( $ ) {
 		post_id: jQuery( '#post_ID' ).val(),
 	};
 
-	const toggleWarningBadges = function( container, response ) {
+	const toggleWarningBadges = function( container, { userHasNoAccess, userHasNoEmail } ) {
 		const $el = jQuery( container ).parent();
 		const $badgesContainer = $el.closest( 'li' ).find( '.ef-user-list-badges' );
+
 		// "No Access" If this user was flagged as not having access
-		const userHasNoAccess = response.data.subscribers_with_no_access.includes( parseInt( jQuery( container ).val(), 10 ) );
 		if ( userHasNoAccess ) {
 			addBadgeToEl( $badgesContainer, BADGES.NO_ACCESS );
 		} else {
 			removeBadgeFromEl( $badgesContainer, BADGES.NO_ACCESS );
 		}
 
 		// "No Email" If this user was flagged as not having an email
-		const userHasNoEmail = response.data.subscribers_with_no_email.includes( parseInt( jQuery( container ).val(), 10 ) );
 		if ( userHasNoEmail ) {
 			addBadgeToEl( $badgesContainer, BADGES.NO_EMAIL );
 		} else {
@@ -140,11 +139,19 @@ jQuery( document ).ready( function( $ ) {
 			success: function( response ) {
 				// Toggle the warning badges ("No Access" and "No Email") to signal the user won't receive notifications
 				if ( undefined !== response.data ) {
-					toggleWarningBadges( jQuery( parentThis ), response );
+					const userHasNoAccess = response.data.subscribers_with_no_access.includes( parseInt( jQuery( container ).val(), 10 ) );
+					const userHasNoEmail = response.data.subscribers_with_no_email.includes( parseInt( jQuery( container ).val(), 10 ) );
+
+					toggleWarningBadges( jQuery( parentThis ), { userHasNoAccess, userHasNoEmail } );
 				}
 
 				// Green 40% by default
-				const backgroundHighlightColor = '#90d296';
+				let backgroundHighlightColor = '#90d296';
+
+				if ( userHasNoAccess || userHasNoEmail ) {
+					// Red 40% if there's a warning
+					backgroundHighlightColor = "#ea8484";
+				}
 
 				const backgroundColor = 'transparent';
 				jQuery( parentThis.parents( 'label' ) )

modules/notifications/lib/notifications.js

@@ -773,7 +773,7 @@ function usergroups_select_form( $selected = array(), $args = null ) {
 				?>
 				<li>
 					<label for="<?php echo $input_id . esc_attr( $usergroup->term_id ); ?>" title="<?php echo esc_attr($usergroup->description) ?>">
-						<div class="ef-user-subscribe-actions">
+						<div class="ef-user-subscribe-action">
 							<input type="checkbox" id="<?php echo esc_attr( $input_id . $usergroup->term_id ) ?>" name="<?php echo esc_attr( $input_id )?>[]" value="<?php echo esc_attr( $usergroup->term_id ) ?>"<?php echo $checked ?> />
 						</div>
 						<span class="ef-usergroup_name"><?php echo esc_html( $usergroup->name ); ?></span>