Updates to tests

Author: Connor Jennings

modules/custom-status/custom-status.php

@@ -1763,16 +1763,20 @@ public function fix_post_row_actions( $actions, $post ) {
 	 * @return bool
 	 */
 	public function is_custom_status_view() {
+		
 		if( $this->is_current_module_settings_view() ) {
 			return true;
 		}
+
 		if( ! $this->is_active_view( array( 'post.php', 'edit.php', 'post-new.php', 'page.php', 'edit-pages.php', 'page-new.php' ) ) ) {
 			return false;
 		}
+
 		$post_type_obj = get_post_type_object( $this->get_current_post_type() );
 		if( $post_type_obj && ! current_user_can( $post_type_obj->cap->edit_posts ) ) {
 			return false;
 		}
+
 		return true;
 	}
 

tests/test-edit-flow-custom-status.php

@@ -3,31 +3,40 @@
 class WP_Test_Edit_Flow_Custom_Status extends WP_UnitTestCase {
 
 	protected static $admin_user_id;
-	protected static $EF_Custom_Status;
+	protected $old_wp_scripts;
 
 	public static function wpSetUpBeforeClass( $factory ) {
+		global $edit_flow;
+
 		self::$admin_user_id = $factory->user->create( array( 'role' => 'administrator' ) );
 
-		self::$EF_Custom_Status = new EF_Custom_Status();
-		self::$EF_Custom_Status->install();
-		self::$EF_Custom_Status->init();
+		$edit_flow->custom_status->install();
+		$edit_flow->custom_status->init();
 	}
 
 	public static function wpTearDownAfterClass() {
 		self::delete_user( self::$admin_user_id );
-		self::$EF_Custom_Status = null;
 	}
 
 	function setUp() {
 		parent::setUp();
 
+		$this->old_wp_scripts = isset( $GLOBALS['wp_scripts'] ) ? $GLOBALS['wp_scripts'] : null;
+		remove_action( 'wp_default_scripts', 'wp_default_scripts' );
+		remove_action( 'wp_default_scripts', 'wp_default_packages' );
+		$GLOBALS['wp_scripts']                  = new WP_Scripts();
+		$GLOBALS['wp_scripts']->default_version = get_bloginfo( 'version' );
+
 		global $pagenow;
 		$pagenow = 'post.php';
 	}
 
 	function tearDown() {
-		parent::tearDown();
+		$GLOBALS['wp_scripts'] = $this->old_wp_scripts;
+		add_action( 'wp_default_scripts', 'wp_default_scripts' );
 
+		parent::tearDown();
+		
 		global $pagenow;
 		$pagenow = 'index.php';
 	}
@@ -332,4 +341,99 @@ public function test_fix_get_sample_permalink_should_respect_hierarchy_of_publis
 		$this->assertSame( home_url() . '/publish-parent-page/%pagename%/', $actual[0] );
 		$this->assertSame( 'child-page', $actual[1] );
 	}
+	
+	/**
+	 * On the custom status settings page, the custom status settings js should be enqueued
+	 */
+	public function test_scripts_enqueued_custom_status_settings_screen() {
+		global $edit_flow, $pagenow, $wp_scripts;
+
+		wp_default_scripts( $wp_scripts );
+		wp_default_packages( $wp_scripts );
+
+		$pagenow = 'admin.php';
+		$_GET['page'] = 'ef-custom-status-settings';
+
+		// Custom Status Settings JS has a dependency on `edit-flow-settings-js`
+		$edit_flow->settings->action_admin_enqueue_scripts();
+		$edit_flow->custom_status->enqueue_admin_scripts();
+
+		$expected = "<script type='text/javascript' src='" . $edit_flow->custom_status->module_url . "lib/custom-status-configure.js?ver=" . EDIT_FLOW_VERSION . "'></script>";
+
+		$footer = get_echo( 'wp_print_footer_scripts' );
+
+		$this->assertContains( $expected, $footer );
+
+	}
+
+	/**
+	 * The custom status settings js should not be enqueued on pages other than the
+	 * custom status settings page
+	 */
+	public function test_scripts_not_enqueued_custom_status_settings_screen() {
+		global $edit_flow, $pagenow, $wp_scripts;
+
+		wp_default_scripts( $wp_scripts );
+		wp_default_packages( $wp_scripts );
+
+		$pagenow = 'post-new.php';
+
+		$edit_flow->settings->action_admin_enqueue_scripts();
+		$edit_flow->custom_status->enqueue_admin_scripts();
+
+		$expected = "<script type='text/javascript' src='" . $edit_flow->custom_status->module_url . "lib/custom-status-configure.js?ver=" . EDIT_FLOW_VERSION . "'></script>";
+
+		$footer = get_echo( 'wp_print_footer_scripts' );
+
+		$this->assertNotContains( $expected, $footer );
+	}
+
+	/**
+	 * The custom status js should be enqueued on pages like post.php with a valid post type
+	 */
+	public function test_scripts_enqueued_custom_status_post() {
+		global $edit_flow, $pagenow, $wp_scripts;
+
+		set_current_screen( 'admin' );
+
+		wp_default_scripts( $wp_scripts );
+		wp_default_packages( $wp_scripts );
+
+		$pagenow = 'post-new.php';
+		$_REQUEST['post_type'] = 'post';
+
+		wp_set_current_user( self::$admin_user_id );
+
+		$edit_flow->custom_status->enqueue_admin_scripts();
+
+		$expected = "<script type='text/javascript' src='" . $edit_flow->custom_status->module_url . "lib/custom-status.js?ver=" . EDIT_FLOW_VERSION . "'></script>";
+
+		$footer = get_echo( 'wp_print_footer_scripts' );
+
+		$this->assertContains( $expected, $footer );
+	}
+
+	/**
+	 * The custom status js should not be enqueued on pages like admin.php
+	 */
+	public function test_scripts_not_enqueued_custom_status_admin() {
+		global $edit_flow, $pagenow, $wp_scripts;
+
+		set_current_screen( 'admin' );
+
+		wp_default_scripts( $wp_scripts );
+		wp_default_packages( $wp_scripts );
+
+		$pagenow = 'admin.php';
+
+		wp_set_current_user( self::$admin_user_id );
+
+		$edit_flow->custom_status->enqueue_admin_scripts();
+
+		$expected = "<script type='text/javascript' src='" . $edit_flow->custom_status->module_url . "lib/custom-status.js?ver=" . EDIT_FLOW_VERSION . "'></script>";
+
+		$footer = get_echo( 'wp_print_footer_scripts' );
+
+		$this->assertNotContains( $expected, $footer );
+	}
 }