refactor: most pub use lines in mod.rs not needed (#2259)

* refactor: most `pub use` lines in `mod.rs` not needed

* fix: fmt

* docs: new linters probably won't need `pub use` in `mod.rs`

Author: hippietrail

harper-core/src/linting/after_later.rs

@@ -73,7 +73,8 @@ impl ExprLinter for AfterLater {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{AfterLater, tests::assert_top3_suggestion_result};
+    use super::AfterLater;
+    use crate::linting::tests::assert_top3_suggestion_result;
 
     #[test]
     fn after_90_days_later() {

harper-core/src/linting/allow_to.rs

@@ -56,10 +56,8 @@ impl ExprLinter for AllowTo {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{
-        AllowTo,
-        tests::{assert_lint_count, assert_no_lints},
-    };
+    use super::AllowTo;
+    use crate::linting::tests::{assert_lint_count, assert_no_lints};
 
     #[test]
     fn flag_allow_to() {

harper-core/src/linting/and_in.rs

@@ -46,10 +46,8 @@ impl ExprLinter for AndIn {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{
-        AndIn,
-        tests::{assert_no_lints, assert_suggestion_result},
-    };
+    use super::AndIn;
+    use crate::linting::tests::{assert_no_lints, assert_suggestion_result};
 
     #[test]
     fn dont_flag_an_in_house() {

harper-core/src/linting/cautionary_tale.rs

@@ -57,10 +57,8 @@ impl ExprLinter for CautionaryTale {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{
-        CautionaryTale,
-        tests::{assert_lint_count, assert_suggestion_result},
-    };
+    use super::CautionaryTale;
+    use crate::linting::tests::{assert_lint_count, assert_suggestion_result};
 
     #[test]
     fn catches_cautionary_tail() {

harper-core/src/linting/change_tack.rs

@@ -64,7 +64,8 @@ impl ExprLinter for ChangeTack {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{ChangeTack, tests::assert_suggestion_result};
+    use super::ChangeTack;
+    use crate::linting::tests::assert_suggestion_result;
 
     // Verbs: change tack
 

harper-core/src/linting/far_be_it.rs

@@ -65,9 +65,9 @@ impl ExprLinter for FarBeIt {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{
-        FarBeIt,
-        tests::{assert_no_lints, assert_suggestion_count, assert_suggestion_result},
+    use super::FarBeIt;
+    use crate::linting::tests::{
+        assert_no_lints, assert_suggestion_count, assert_suggestion_result,
     };
 
     #[test]

harper-core/src/linting/go_so_far_as_to.rs

@@ -77,10 +77,8 @@ impl ExprLinter for GoSoFarAsTo {
 
 #[cfg(test)]
 mod tests {
-    use crate::linting::{
-        GoSoFarAsTo,
-        tests::{assert_no_lints, assert_suggestion_result},
-    };
+    use super::GoSoFarAsTo;
+    use crate::linting::tests::{assert_no_lints, assert_suggestion_result};
 
     #[test]
     fn go_so_far_to() {

harper-core/src/linting/have_take_a_look.rs

@@ -93,10 +93,8 @@ impl ExprLinter for HaveTakeALook {
 
 #[cfg(test)]
 mod tests {
-    use crate::{
-        Dialect,
-        linting::{HaveTakeALook, tests::assert_suggestion_result},
-    };
+    use super::HaveTakeALook;
+    use crate::{Dialect, linting::tests::assert_suggestion_result};
 
     #[test]
     fn correct_taking_a_look() {

harper-core/src/linting/in_on_the_cards.rs

@@ -88,12 +88,10 @@ impl ExprLinter for InOnTheCards {
 
 #[cfg(test)]
 mod tests {
+    use super::InOnTheCards;
     use crate::{
         Dialect,
-        linting::{
-            InOnTheCards,
-            tests::{assert_lint_count, assert_suggestion_result},
-        },
+        linting::tests::{assert_lint_count, assert_suggestion_result},
     };
 
     // On the cards

harper-core/src/linting/lint_group.rs

@@ -43,6 +43,7 @@ use super::compound_subject_i::CompoundSubjectI;
 use super::confident::Confident;
 use super::correct_number_suffix::CorrectNumberSuffix;
 use super::criteria_phenomena::CriteriaPhenomena;
+use super::currency_placement::CurrencyPlacement;
 use super::despite_of::DespiteOf;
 use super::didnt::Didnt;
 use super::discourse_markers::DiscourseMarkers;
@@ -88,6 +89,7 @@ use super::lets_confusion::LetsConfusion;
 use super::likewise::Likewise;
 use super::long_sentences::LongSentences;
 use super::looking_forward_to::LookingForwardTo;
+use super::mass_plurals::MassPlurals;
 use super::merge_words::MergeWords;
 use super::missing_preposition::MissingPreposition;
 use super::missing_to::MissingTo;
@@ -104,9 +106,11 @@ use super::nail_on_the_head::NailOnTheHead;
 use super::need_to_noun::NeedToNoun;
 use super::no_french_spaces::NoFrenchSpaces;
 use super::no_match_for::NoMatchFor;
+use super::no_oxford_comma::NoOxfordComma;
 use super::nobody::Nobody;
 use super::nominal_wants::NominalWants;
 use super::noun_countability::NounCountability;
+use super::noun_verb_confusion::NounVerbConfusion;
 use super::number_suffix_capitalization::NumberSuffixCapitalization;
 use super::of_course::OfCourse;
 use super::on_floor::OnFloor;
@@ -116,6 +120,7 @@ use super::open_the_light::OpenTheLight;
 use super::orthographic_consistency::OrthographicConsistency;
 use super::ought_to_be::OughtToBe;
 use super::out_of_date::OutOfDate;
+use super::oxford_comma::OxfordComma;
 use super::oxymorons::Oxymorons;
 use super::phrasal_verb_as_compound_noun::PhrasalVerbAsCompoundNoun;
 use super::pique_interest::PiqueInterest;
@@ -179,15 +184,12 @@ use super::widely_accepted::WidelyAccepted;
 use super::win_prize::WinPrize;
 use super::wordpress_dotcom::WordPressDotcom;
 use super::would_never_have::WouldNeverHave;
-use super::{CurrencyPlacement, HtmlDescriptionLinter, Linter, NoOxfordComma, OxfordComma};
 use super::{ExprLinter, Lint};
+use super::{HtmlDescriptionLinter, Linter};
 use crate::linting::dashes::Dashes;
 use crate::linting::expr_linter::Chunk;
 use crate::linting::open_compounds::OpenCompounds;
-use crate::linting::{
-    MassPlurals, NounVerbConfusion, closed_compounds, initialisms, phrase_corrections,
-    phrase_set_corrections,
-};
+use crate::linting::{closed_compounds, initialisms, phrase_corrections, phrase_set_corrections};
 use crate::spell::{Dictionary, MutableDictionary};
 use crate::{CharString, Dialect, Document, TokenStringExt};