Forms: Fix loading state to show spinner immediately

Prevents empty state flash by showing loading spinner when data hasn't resolved yet.

Related: #45339

Author: lezama

projects/packages/forms/changelog/optimize-inbox-loading-state

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Forms: improve loading state to show spinner immediately when data hasn't loaded.

projects/packages/forms/src/dashboard/hooks/use-inbox-data.ts

@@ -70,7 +70,7 @@ export default function useInboxData(): UseInboxDataReturn {
 
 	const {
 		records: rawRecords,
-		isResolving: isLoadingRecordsData,
+		hasResolved,
 		totalItems,
 		totalPages,
 	} = useEntityRecords( 'postType', 'feedback', currentQuery );
@@ -116,13 +116,18 @@ export default function useInboxData(): UseInboxDataReturn {
 		}
 	);
 
+	const isLoadingData =
+		( ! rawRecords?.length && ! hasResolved ) ||
+		isLoadingInboxData ||
+		isLoadingSpamData ||
+		isLoadingTrashData;
+
 	return {
 		totalItemsInbox,
 		totalItemsSpam,
 		totalItemsTrash,
 		records,
-		isLoadingData:
-			isLoadingRecordsData || isLoadingInboxData || isLoadingSpamData || isLoadingTrashData,
+		isLoadingData,
 		totalItems,
 		totalPages,
 		selectedResponsesCount,