From 6d4b8b11181eae01215c61f62ab5b0c21b1d780b Mon Sep 17 00:00:00 2001 From: Christian Gastrell Date: Thu, 10 Apr 2025 17:41:04 -0300 Subject: [PATCH 1/2] tweak useSelect call to comply with latest best practices --- .../components/seo-enhancer/use-seo-requests.ts | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-enhancer/use-seo-requests.ts b/projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-enhancer/use-seo-requests.ts index db1c86d8fbfdd..e6ebdb54187c5 100644 --- a/projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-enhancer/use-seo-requests.ts +++ b/projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-enhancer/use-seo-requests.ts @@ -46,15 +46,16 @@ export const useSeoRequests = () => { const { updateBlockAttributes } = useDispatch( 'core/block-editor' ); const postId = useSelect( select => select( editorStore ).getCurrentPostId(), [] ); const { getPostContent } = usePostContent(); - const { isBusy, enabledFeatures } = useSelect( select => { - const busy = select( store ).isBusy(); - const features = select( store ).getEnabledFeatures(); - - return { isBusy: busy, enabledFeatures: features }; + const { isBusy, enabledFeatures, isImageBusy, hasImageFailed } = useSelect( select => { + return { + isBusy: select( store ).isBusy(), + enabledFeatures: select( store ).getEnabledFeatures(), + isImageBusy: select( store ).isImageBusy, + hasImageFailed: select( store ).hasImageFailed, + }; }, [] ); - const { setBusy, setTitleBusy, setDescriptionBusy } = useDispatch( store ); - const { isImageBusy, hasImageFailed } = useSelect( select => select( store ), [] ); - const { setImageBusy, setImageFailed } = useDispatch( store ); + const { setBusy, setTitleBusy, setDescriptionBusy, setImageBusy, setImageFailed } = + useDispatch( store ); const { createInfoNotice } = useDispatch( 'core/notices' ); const { increaseRequestsCount, dequeueAsyncRequest, requireUpgrade } = useAiFeature(); const [ triggerType, setTriggerType ] = useState< 'manual' | 'auto' >( null ); From c33f3f8c0f8bc7f3dd22b9ba55f822a07e1bbac2 Mon Sep 17 00:00:00 2001 From: Christian Gastrell Date: Thu, 10 Apr 2025 17:41:48 -0300 Subject: [PATCH 2/2] changelog --- .../jetpack/changelog/fix-jetpack-seo-bad-useselect-call | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 projects/plugins/jetpack/changelog/fix-jetpack-seo-bad-useselect-call diff --git a/projects/plugins/jetpack/changelog/fix-jetpack-seo-bad-useselect-call b/projects/plugins/jetpack/changelog/fix-jetpack-seo-bad-useselect-call new file mode 100644 index 0000000000000..8972dfe121f06 --- /dev/null +++ b/projects/plugins/jetpack/changelog/fix-jetpack-seo-bad-useselect-call @@ -0,0 +1,4 @@ +Significance: minor +Type: other + +Jetpack SEO Enhacner: change useSelect call to comply with more performant practices