Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline text styles have minor display issues in editor #990

Open
laurelfulford opened this issue Oct 19, 2022 · 0 comments
Open

Inline text styles have minor display issues in editor #990

laurelfulford opened this issue Oct 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@laurelfulford
Copy link
Contributor

Using the inline text styles cause some unexpected issue in the editor.

  1. Create a new newsletter.
  2. If not already, set your body and headers to different types of fonts: set one to serif and one to sans serif.
  3. Add a Heading to your newsletter.
  4. Use the inline text styles to give one word in your heading a different colour.
  5. Note that the inline colour is not applied, but the word is now styled like your body font. In my case, the headings should be sans-serif, but using the inline text highlight made one word serif:

image

The culprit seems to be the mark tag that the inline styles use -- they're picking up this style in the editor instead of the heading font face:

.editor-styles-wrapper .block-editor-block-list__layout :not(code) {
  font-family: var(--newspack-body-font);
}

The inline colour options don't seem to be working because the has-primary-color styles aren't available in the header -- for other elements, the colours are applied inline.

Both of these styles appear to work as expected in the sent newsletter -- the header using the inline style all uses the correct font family, and the inline text is applied:

image

@laurelfulford laurelfulford added the bug Something isn't working label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant