fix failing tests

Author: MrJnrman

tests/payments-test-packages/CODE_CHANGES.md

@@ -48,7 +48,42 @@ find ./bootstrap -type f -exec sed -i 's|/qit/bootstrap|./bootstrap|g' {} +
 
 ---
 
-## 2. QIT Helpers Import Changes
+## 2. Bootstrap Test User Creation
+
+**Why**: Tests expect specific users (from `config/users.json`) to exist. Your bootstrap must create them with matching credentials.
+
+### bootstrap/setup.sh
+
+Add user creation commands:
+
+```bash
+# Create test users matching config/users.json
+wp user create customer [email protected] \
+    --role=customer \
+    --user_pass=password \
+    --first_name="Jane" \
+    --last_name="Smith" \
+    --quiet 2>/dev/null || wp user update customer --user_pass=password --quiet
+
+wp user create subscriptions-customer [email protected] \
+    --role=customer \
+    --user_pass=password \
+    --quiet 2>/dev/null || wp user update subscriptions-customer --user_pass=password --quiet
+
+wp user create editor [email protected] \
+    --role=editor \
+    --user_pass=password \
+    --quiet 2>/dev/null || wp user update editor --user_pass=password --quiet
+```
+
+**Important**:
+- Usernames and passwords must match `config/users.json`
+- The `|| wp user update` fallback handles cases where the user already exists
+- Without these users, authentication will fail in tests
+
+---
+
+## 3. QIT Helpers Import Changes
 
 **Why**: Legacy tests used global `/qitHelpers` module. Test packages use local `@qit/helpers` package.
 
@@ -78,7 +113,7 @@ find . -name "*.ts" -o -name "*.js" | xargs sed -i "s|from '/qitHelpers'|from '@
 
 ---
 
-## 3. JSON Import Changes
+## 4. JSON Import Changes
 
 **Why**: ES modules require import attributes for JSON files.
 
@@ -121,7 +156,7 @@ grep -r "from.*\.json" . --include="*.ts" --include="*.js"
 
 ---
 
-## 4. `__dirname` Shim for ES Modules
+## 5. `__dirname` Shim for ES Modules
 
 **Why**: ES modules don't provide `__dirname` global like CommonJS does.
 
@@ -163,7 +198,7 @@ grep -r "__dirname" . --include="*.ts" --include="*.js"
 
 ---
 
-## 5. Required Dependencies
+## 6. Required Dependencies
 
 **Why**: ES modules need Node.js type definitions, and QIT requires Allure reports.
 
@@ -195,7 +230,7 @@ grep -r "__dirname" . --include="*.ts" --include="*.js"
 
 ---
 
-## 6. RestAPI Import
+## 7. RestAPI Import
 
 **Why**: `RestAPI` class needs to be imported if used in helper functions.
 
@@ -235,7 +270,7 @@ export const getShopper = async (
 
 ---
 
-## 7. Playwright Reporter Configuration
+## 8. Playwright Reporter Configuration
 
 **Why**: QIT requires specific reporters to be configured for test results and Allure reports.
 
@@ -284,7 +319,7 @@ export default defineConfig({
 
 ---
 
-## 8. Test Package Manifest - Allure Directory
+## 9. Test Package Manifest - Allure Directory
 
 **Why**: QIT needs to know where to find Allure results to upload them with test reports.
 
@@ -318,6 +353,7 @@ Add `allure-dir` to the `results` section:
 When migrating tests to test packages, check for these code changes:
 
 - [ ] Replace `/qit/bootstrap/` with `./bootstrap/` in all bootstrap scripts
+- [ ] Create test users in bootstrap matching `config/users.json` (customer, editor, etc.)
 - [ ] Replace `/qitHelpers` with `@qit/helpers` in all test files
 - [ ] Add `with { type: 'json' }` to JSON imports
 - [ ] Use default imports for JSON files

tests/payments-test-packages/GETTING_STARTED.md

@@ -101,22 +101,23 @@ cp /path/to/my-plugin/tests/qit/e2e/bootstrap/*.sh ./bootstrap/
 cp /path/to/my-plugin/tests/qit/e2e/bootstrap/*.php ./bootstrap/
 ```
 
-**IMPORTANT**: Old tests used absolute paths (`/qit/bootstrap/`). These need to change to relative paths (`./bootstrap/`):
+**IMPORTANT**: Two changes are needed in bootstrap scripts:
 
-```bash
-# Find files with old paths
-grep -r "/qit/bootstrap" ./bootstrap/
+1. **Fix paths** - Replace `/qit/bootstrap/` with `./bootstrap/`
 
-# Replace with relative paths (macOS)
-find ./bootstrap -type f -exec sed -i '' 's|/qit/bootstrap|./bootstrap|g' {} +
+2. **Create correct test users** - Your bootstrap must create users matching `config/users.json`:
 
-# Or on Linux
-find ./bootstrap -type f -exec sed -i 's|/qit/bootstrap|./bootstrap|g' {} +
+```bash
+# In bootstrap/setup.sh, create users with these exact credentials:
+wp user create customer [email protected] \
+    --role=customer --user_pass=password --quiet
 
-# Verify the change worked (should return nothing)
-grep -r "/qit/bootstrap" ./bootstrap/
+wp user create editor [email protected] \
+    --role=editor --user_pass=password --quiet
 ```
 
+See [CODE_CHANGES.md](./CODE_CHANGES.md#1-bootstrap-path-changes) for details.
+
 ---
 
 ### Step 4: Add QIT Helpers

tests/payments-test-packages/bootstrap/setup.sh

@@ -96,13 +96,32 @@ wp theme activate storefront
 
 
 
-# Create a test customer
-wp user create testcustomer [email protected] \
+# Create test users that match config/users.json
+# Customer user (required for shopper tests)
+wp user create customer [email protected] \
     --role=customer \
-    --user_pass=testpass123 \
-    --first_name="Test" \
+    --user_pass=password \
+    --first_name="Jane" \
+    --last_name="Smith" \
+    --quiet 2>/dev/null || wp user update customer --user_pass=password --quiet
+
+# Subscriptions customer user (required for subscription tests)
+wp user create subscriptions-customer [email protected] \
+    --role=customer \
+    --user_pass=password \
+    --first_name="Sub" \
     --last_name="Customer" \
-    --quiet
+    --quiet 2>/dev/null || wp user update subscriptions-customer --user_pass=password --quiet
+
+# Editor user (required for editor tests)
+wp user create editor [email protected] \
+    --role=editor \
+    --user_pass=password \
+    --first_name="Ed" \
+    --last_name="Itor" \
+    --quiet 2>/dev/null || wp user update editor --user_pass=password --quiet
+
+echo "✅ Test users created (customer, subscriptions-customer, editor)"
 
 echo "Setting up WooPayments configuration..."