Replace PostTypeSupportsValue with JsonValue directly

Simplify post type supports by using JsonValue directly instead of
the PostTypeSupportsValue wrapper type. Tests now use the supports
method on PostTypeSupportsMap to check feature support.

Changes:
- Change PostTypeSupportsMap.map from HashMap<_, Arc<PostTypeSupportsValue>> to HashMap<_, JsonValue>
- Remove PostTypeSupportsValue struct and its impl block
- Update Rust test to use supports method directly
- Update Kotlin test to use postTypeSupports helper

Author: oguzkocer

native/kotlin/api/kotlin/src/integrationTest/kotlin/PostTypesEndpointTest.kt

@@ -6,6 +6,7 @@ import uniffi.wp_api.PostType
 import uniffi.wp_api.PostTypeCapabilities
 import uniffi.wp_api.PostTypeSupports
 import uniffi.wp_api.WpErrorCode
+import uniffi.wp_api.postTypeSupports
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertNull
@@ -26,7 +27,7 @@ class PostTypesEndpointTest {
         val postTypesPost = client.request { requestBuilder ->
             requestBuilder.postTypes().retrieveWithEditContext(PostType.Post)
         }.assertSuccessAndRetrieveData().data
-        assert(postTypesPost.supports.map[PostTypeSupports.Title]!!.asJsonBool()!!)
+        assert(postTypeSupports(postTypesPost.supports, PostTypeSupports.Title))
         assertFalse(postTypesPost.capabilities[PostTypeCapabilities.EditPosts]!!.isEmpty())
     }
 

wp_api/src/post_types.rs

@@ -2,7 +2,6 @@ use crate::{JsonValue, impl_as_query_value_from_to_string};
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
 use std::str::FromStr;
-use std::sync::Arc;
 use wp_contextual::WpContextual;
 use wp_serde_helper::deserialize_empty_array_or_hashmap;
 
@@ -98,7 +97,7 @@ pub struct PostTypeSupportsMap {
     #[serde(deserialize_with = "deserialize_empty_array_or_hashmap")]
     #[serde(flatten)]
     #[serde(rename = "supports")]
-    pub map: HashMap<PostTypeSupports, Arc<PostTypeSupportsValue>>,
+    pub map: HashMap<PostTypeSupports, JsonValue>,
 }
 
 impl PostTypeSupportsMap {
@@ -123,27 +122,6 @@ fn post_type_supports(supports_map: &PostTypeSupportsMap, feature: PostTypeSuppo
     supports_map.supports(&feature)
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, uniffi::Object)]
-#[serde(transparent)]
-pub struct PostTypeSupportsValue {
-    #[serde(flatten)]
-    pub json_value: JsonValue,
-}
-
-#[uniffi::export]
-impl PostTypeSupportsValue {
-    fn as_json_value(&self) -> JsonValue {
-        self.json_value.clone()
-    }
-
-    pub fn as_json_bool(&self) -> Option<bool> {
-        match self.json_value {
-            JsonValue::Bool(b) => Some(b),
-            _ => None,
-        }
-    }
-}
-
 #[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize, uniffi::Record)]
 pub struct PostTypeLabels {
     pub name: String,

wp_api_integration_tests/tests/test_post_types_immut.rs

@@ -92,14 +92,7 @@ async fn retrieve_post_types_with_edit_context(
     // It's possible that we might have more test sites in the future and some of their
     // post types might not support `Title` in which case it's perfectly fine to completely
     // remove this assertion.
-    assert_eq!(
-        post_type
-            .supports
-            .map
-            .get(&PostTypeSupports::Title)
-            .and_then(|v| v.as_json_bool()),
-        Some(true)
-    );
+    assert!(post_type.supports.supports(&PostTypeSupports::Title));
     // All post types in our current testing sites have `EditPost` capability, so we use this
     // assertion to verify that we are able to parse `capabilities` field properly.
     //