Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of things I noticed... #11

Open
Rumyra opened this issue Jan 21, 2018 · 2 comments
Open

A couple of things I noticed... #11

Rumyra opened this issue Jan 21, 2018 · 2 comments

Comments

@Rumyra
Copy link

Rumyra commented Jan 21, 2018

Mostly unimportant but I thought I'd record them and then do a PR when I have some time as a thanks for letting me clone...

overflow: none; is not a thing - i.e. none is not a taken value here. You're probably looking for overflow: visible which is default or auto would work but this is 'let the browser decide'
• the manifest spec changed, so instead of a manifest.json file you want a marcusblog.webmanifest - should work with a rename as it's just the extension & still JSON. See https://github.com/Rumyra/blog-rumyra/blob/master/src/rumyrasblog.webmanifest

@Rumyra
Copy link
Author

Rumyra commented Jan 21, 2018

Apologies if you know these things and this is actually a total womansplain! omg

@AverageMarcus
Copy link
Owner

😆 Guessing I meant to do overflow: hidden;

Yeah, been meaning to sort the manifest but as I'm not aiming for it being a PWA app it's not been a high priority to sort out. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants