Skip to content

Commit

Permalink
Remove type attribute on a elements and remove unnecessary type attri…
Browse files Browse the repository at this point in the history
…bute on javascript tags
  • Loading branch information
Awoyalejohn committed Aug 29, 2022
1 parent 6dc1fd6 commit 5b6f893
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion profiles/templates/profiles/profile_billing_details.html
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,5 @@ <h2 class="section-heading">My Profile</h2>

{% block postloadjs %}
{{ block.super }}
<script type="text/javascript" src="{% static 'profiles/js/countryfield.js' %}"></script>
<script src="{% static 'profiles/js/countryfield.js' %}"></script>
{% endblock %}
4 changes: 2 additions & 2 deletions profiles/templates/profiles/profile_reviews.html
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ <h2 class="section-heading">My Profile</h2>
</div>
<div class="card-body">
<div class="d-flex justify-content-end align-items-center">
<a type="button" href="{% url 'edit_review' review.id %}" class="btn btn-sm btn-outline-info mx-1">Edit</a>
<a type="button" href="{% url 'delete_review' review.id %}" class="btn btn-sm btn-outline-light mx-1">Delete</a>
<a href="{% url 'edit_review' review.id %}" class="btn btn-sm btn-outline-info mx-1">Edit</a>
<a href="{% url 'delete_review' review.id %}" class="btn btn-sm btn-outline-light mx-1">Delete</a>
</div>
</div>
</div><!-- end/ Bootstrap card-->
Expand Down
2 changes: 1 addition & 1 deletion quotes/templates/quotes/quote_checkout_success.html
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ <h2 class="section-heading">Thank You</h2>
{% block postloadjs %}
{{ block.super }}
<script src="{% static 'checkout/js/download.js' %}"></script>
<script type="text/javascript">
<script>
const tooltipTriggerList = document.querySelectorAll('[data-bs-toggle="tooltip"]')
const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl))
</script>
Expand Down
2 changes: 1 addition & 1 deletion quotes/templates/quotes/quote_history.html
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ <h2 class="section-heading">My Profile</h2>
{% block postloadjs %}
{{ block.super }}
<script src="{% static 'checkout/js/download.js' %}"></script>
<script type="text/javascript">
<script>
const tooltipTriggerList = document.querySelectorAll('[data-bs-toggle="tooltip"]')
const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl))
</script>
Expand Down
4 changes: 2 additions & 2 deletions testimonials/templates/testimonials/testimonial_list.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ <h5>{{ testimonial.user.user }}</h5>
<!-- Card buttons -->
{% if request.user.is_superuser or request.user == testimonial.user.user %}
<div class="d-flex justify-content-end align-items-center">
<a type="button" href="{% url 'edit_testimonial' testimonial.id %}" class="btn btn-sm btn-outline-info mx-1">Edit</a>
<a type="button" href="{% url 'delete_testimonial' testimonial.id %}" class="btn btn-sm btn-outline-light mx-1">Delete</a>
<a href="{% url 'edit_testimonial' testimonial.id %}" class="btn btn-sm btn-outline-info mx-1">Edit</a>
<a href="{% url 'delete_testimonial' testimonial.id %}" class="btn btn-sm btn-outline-light mx-1">Delete</a>
</div>
{% endif %}

Expand Down
4 changes: 2 additions & 2 deletions wishlist/templates/wishlist/wish_list.html
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ <h5 class="card-title">Your wish list is empty</h5>
</div>
<div class="card-body">

<a type="button" href="{% url 'products' %}" class="btn btn-outline-light">
<a href="{% url 'products' %}" class="btn btn-outline-light">
<i class="fas fa-chevron-left"></i>Keep shopping
</a>
</div>
Expand All @@ -152,7 +152,7 @@ <h5 class="card-title">Your wish list is empty</h5>

{% block postloadjs %}
{{ block.super }}
<script type="text/javascript">
<script>
const removeItems = document.querySelectorAll(".remove-item")
for (let removeItem of removeItems) {
removeItem.addEventListener('click', function() {
Expand Down

0 comments on commit 5b6f893

Please sign in to comment.