chore: better logging in e2e tests when VHD doesn't exist (#5912)

timmy-wright · web-flow · commit cb1d2c652e9b · 2025-02-26T09:28:25.000+13:00
diff --git a/e2e/scenario_helpers_test.go b/e2e/scenario_helpers_test.go
@@ -180,9 +180,9 @@ func maybeSkipScenario(ctx context.Context, t *testing.T, s *Scenario) {
 	vhd, err := s.VHD.VHDResourceID(ctx, t)
 	if err != nil {
 		if config.Config.IgnoreScenariosWithMissingVHD && errors.Is(err, config.ErrNotFound) {
-			t.Skipf("skipping scenario %q: could not find image", t.Name())
+			t.Skipf("skipping scenario %q: could not find image for VHD %s due to %s", t.Name(), s.VHD.String(), err)
 		} else {
-			t.Fatalf("could not find image for %q: %s", t.Name(), err)
+			t.Fatalf("could not find image for %q (VHD %s): %s", t.Name(), s.VHD.String(), err)
 		}
 	}
 	t.Logf("VHD: %q, TAGS %+v", vhd, s.Tags)

Original file line number	Diff line number	Diff line change
`@@ -180,9 +180,9 @@ func maybeSkipScenario(ctx context.Context, t testing.T, s Scenario) {`
`180`	`180`	`vhd, err := s.VHD.VHDResourceID(ctx, t)`
`181`	`181`	`if err != nil {`
`182`	`182`	`if config.Config.IgnoreScenariosWithMissingVHD && errors.Is(err, config.ErrNotFound) {`
`183`		`- t.Skipf("skipping scenario %q: could not find image", t.Name())`
	`183`	`+ t.Skipf("skipping scenario %q: could not find image for VHD %s due to %s", t.Name(), s.VHD.String(), err)`
`184`	`184`	`} else {`
`185`		`- t.Fatalf("could not find image for %q: %s", t.Name(), err)`
	`185`	`+ t.Fatalf("could not find image for %q (VHD %s): %s", t.Name(), s.VHD.String(), err)`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`	`t.Logf("VHD: %q, TAGS %+v", vhd, s.Tags)`