Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate error for DPG model serialization and deserialization #2283

Closed
tadelesh opened this issue Nov 28, 2023 · 2 comments
Closed

Consolidate error for DPG model serialization and deserialization #2283

tadelesh opened this issue Nov 28, 2023 · 2 comments
Assignees
@tadelesh
Labels
p1 serialization Serialization and deserialization for sending to network

Comments

@tadelesh
Copy link
Member

Coming from #2269 (review).
When deserializing, all exception will be wrapped with DeserializationError, but when creating models, the raw error will be exposed though it also contains sort of deserialization. It's better to standardize behavior for all kinds of serialization and deserialization exceptions.
cc: @iscai-msft
@tadelesh tadelesh self-assigned this Nov 28, 2023
@iscai-msft iscai-msft added p1 serialization Serialization and deserialization for sending to network labels Nov 30, 2023
@iscai-msft
Copy link
Contributor

is this still an issue @tadelesh? If so, please reopen on microsoft/typespec

@tadelesh
Copy link
Member Author

reopened here: microsoft/typespec#5597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadelesh tadelesh

Labels
p1 serialization Serialization and deserialization for sending to network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tadelesh @iscai-msft