-
Notifications
You must be signed in to change notification settings - Fork 525
Change feed: Adds id and pk to ChangeFeedMetadata for delete operations #5470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…adata.cs Co-authored-by: Kiran Kumar Kolli <[email protected]>
…adata.cs Co-authored-by: Kiran Kumar Kolli <[email protected]>
kirankumarkolli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change validated E2E with live accounts?
Can we add E2E test (please check with @NaluTripician )
|
Also please update the PR description with usage like how external CX will use it. |
No haven't validated with live accounts. Only with emulator. Let me connect with Nalu |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
Outdated
Show resolved
Hide resolved
…com/Azure/azure-cosmos-dotnet-v3 into users/trivediyash/CFPDeleteMetadata
|
Ref: #5191 (comment) |
…com/Azure/azure-cosmos-dotnet-v3 into users/trivediyash/CFPDeleteMetadata
Description
Adds id and partition key to ChangeFeedMetadata. This is populated for delete operations using all versions all deletes change feed mode so that when customers get the delete, they know what was deleted. Note it doesn't have the value of the document that was deleted only the id and partition key through which a document can be uniquely identified.
Please note that user provided serializer is not being used.
This PR includes commits from #5191 and additional simplifications and unit test changes
Type of change
New feature (non-breaking change which adds functionality)
Basic Usage
Single Partition Key Example
Hierarchical Partition Key Example
Cache Synchronization Example
Property Details
ChangeFeedMetadata.Idstring"order-12345"ChangeFeedMetadata.PartitionKeyDictionary<string, object>/Examples:
Single Partition Key (
/categoryId):Hierarchical Partition Key (
["/tenantId", "/userId", "/sessionId"]):Mixed Types (
["/category", "/priority", "/isActive"]):Notes
IdandPartitionKeyare only populated whenOperationType == DeleteIsTimeToLiveExpiredto distinguish TTL deletes from explicit deletesChangeFeedPolicy.FullFidelityRetentionconfigured