Skip to content

Conversation

@azure-sdk
Copy link

@azure-sdk azure-sdk commented Jan 23, 2023

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.

@ghost
Copy link

ghost commented Jan 23, 2023

Hello @msftbot[bot]!

Because this pull request has the automerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Dev keyvault microsoft.key vault 2022 02 01 preview swagger completeness (#22154)

* Adds base for updating Microsoft.KeyVault from version stable/2022-07-01 to version 2022-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fixed breaking changes in managedHsm.json. (#22112)

Fixed LRO_RESPONSE_HEADER, INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY errors.

Co-authored-by: Rahul Alapati <[email protected]>

* Undid the API version changes to the Vaults_List API (#22142)

* Fixed breaking changes in managedHsm.json.
Fixed LRO_RESPONSE_HEADER, INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY errors.

* Undid the API Version change to the VaultListFilterTypes API.

Co-authored-by: Rahul Alapati <[email protected]>

* Update listVault.json (#22155)

* Update listVault.json

* Remove the preview API version for the enum

* Delete Vault_Lists API specification

* Added the Vaults_List swagger specification back.

* Abstracted Vaults_List API into 2015-11-01 directory to Swagger ModelValidation Errors.

* Resolved unresolvable references.

* Reorganized the definitions.

* Reorganized the 2015-11-01 directory under 2022-02-01-preview

* Moved the 2015-11-10 directory to stable.

* Undo the abstraction changes.

* Readd the listVault.json.

* Added suppression directives for INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY.

* Modify suppress rule.

* Update the suppression directive.

* Update suppression directive.

* Update suppression directive.

* Update suppression directives.

* Updated suppression directive.

* Added suppression directives for INVALID_REQUEST_PARAMETER, OBJECT_MISSING_REQUIRED_PROPERTY

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Added x-ms-validation rules to the api-version parameter.

* Updated suppression directives.

* Added individual suppression directives.

* Removed where clause from the OBJECT_MISSING_REQUIRED_PROPERTY suppression directive.

* Corrected yaml title for suppression directives.

Co-authored-by: Rahul Alapati <[email protected]>

---------

Co-authored-by: Rahul Alapati <[email protected]>
@azure-sdk azure-sdk changed the title [ReleasePR keyvault] [Hub Generated] Review request for Microsoft.KeyVault to add version stable/2022-07-01 [ReleasePR keyvault] Dev keyvault microsoft.key vault 2022 02 01 preview swagger completeness Feb 2, 2023
@ghost ghost merged commit cf0d279 into Azure:main Feb 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant