Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Azure SDK Components in Conan? #6334

Open
2 tasks done
wilyle opened this issue Jan 13, 2025 · 4 comments
Open
2 tasks done

More Azure SDK Components in Conan? #6334

wilyle opened this issue Jan 13, 2025 · 4 comments
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@wilyle
Copy link
Member

wilyle commented Jan 13, 2025

Is your feature request related to a problem? Please describe.
I am using the Conan package manager and would like to use some of the Azure SDK components (specifically the Azure Identity library). I found a package called azure-sdk-for-cpp, but when trying to use it I see it only declares components for core and a few related to storage:

-- Conan: Component target declared 'Azure::azure-core'
-- Conan: Component target declared 'Azure::azure-storage-common'
-- Conan: Component target declared 'Azure::azure-storage-blobs'
-- Conan: Component target declared 'Azure::azure-storage-files-shares'
-- Conan: Target declared 'azure-sdk-for-cpp::azure-sdk-for-cpp'

Is there a reason that only these components are available?

Describe the solution you'd like
Update the Conan package to include other pieces of the Azure SDK, or at least Azure Identity.

Describe alternatives you've considered
We could use VCPKG instead, but there are a lot of reasons we'd rather use Conan. The biggest one is that automated security and license scans don't really work with VCPKG.

Additional context
N/A

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 13, 2025
@wilyle
Copy link
Member Author

wilyle commented Jan 13, 2025

I found #5485 which seems related. Tagging @trns1997 who created the Conan package originally. Would it be possible to update this to include the other Azure components such as identity?

@trns1997
Copy link

Hey @wilyle honestly I do not remember why I didn't not build all the modules? Either I faced problems or I just didn't need them ? conan-io/conan-center-index#23663, here is the link to the PR, I'll look into it when I have the time, but if you are familiar with conan packages and recipes I would suggest adding the module of interest in the cmake wrapper to give it a try :)

@wilyle
Copy link
Member Author

wilyle commented Jan 13, 2025

Thanks for the response! Unfortunately this is my first time using Conan so I'm not sure how much help I'll be. Most of the hard work looks like it's already done so I might be able to give it a shot

@trns1997
Copy link

@wilyle aha, i finally got the time to look into it. Hmm the message might seem misleading but unless you specify that you wish to install a single module, conan by default will build everything (everything = https://github.com/Azure/azure-sdk-for-cpp/blob/main/CMakeLists.txt this entire cmake is executed):
And all you need to do is link azure-sdk-for-cpp::azure-sdk-for-cpp

    find_package(AzureSDK)
    target_link_libraries(... azure-sdk-for-cpp::azure-sdk-for-cpp)

Logically you should have the identity module and any other module that comes with the sdk. Sorry i wanted to create a mechanism that allowed me to install just a single module as in my project i only needed the azure-storage module and the rest was just a waste of time to compile :). I only added the submodule mechanism for modules that interested me as it was easier for me to write the tests and validate it.

Let me know if simply installing and linking the entire sdk package works for you, otherwise ping me, i'll look into this further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

2 participants