Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feature to list subset of revisions using the range request header is defined in the REST API docs but doesn't exist in the typespec spec #6340

Open
ahsonkhan opened this issue Jan 14, 2025 · 2 comments
Assignees
Labels
App Configuration Azure.ApplicationModel.Configuration feature-request This issue requires a new behavior in the product in order be resolved. Service Attention Workflow: This issue is responsible by Azure service team.
Milestone

Comments

@ahsonkhan
Copy link
Contributor

ahsonkhan commented Jan 14, 2025

REST API doc:
https://learn.microsoft.com/en-us/azure/azure-app-configuration/rest-api-revisions?pivots=v23-11#list-subset-of-revisions

The Typespec spec doesn't mention Range:
https://github.com/Azure/azure-rest-api-specs/blob/b6bead0df961af706e984e2b9807c8a099ece61b/specification/appconfiguration/AppConfiguration/routes.tsp#L812

If this capability is necessary, we'd need to get the service team to update the typespec to include this feature.
Until then, we could either hand-implement this, or exclude it from the public surface area, until requested by customers.

Since, the other language SDKs don't have this capability either, we'd follow suite. So, this will be in the backlog for C++ for now.

@ahsonkhan ahsonkhan added App Configuration Azure.ApplicationModel.Configuration feature-request This issue requires a new behavior in the product in order be resolved. Service Attention Workflow: This issue is responsible by Azure service team. labels Jan 14, 2025
@ahsonkhan ahsonkhan added this to the Backlog milestone Jan 14, 2025
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ahsonkhan @antkmsft @gearama @LarryOsterman @RickWinter.

@ahsonkhan
Copy link
Contributor Author

ahsonkhan commented Jan 24, 2025

From the service team:

It looks like an oversight. Revisions endpoint is the only one that supports Range header.

Based on feedback from Typespec and Codegen folks, @avanigupta, this is something we'd want fixed in the service spec.

The goal is for the service's TypeSpec spec to be a true (and a more complete) representation of the public/documented/supported service behavior.

P.S. In this case, since other languages have a convenience layer on top, each language SDK can choose how they would like to wire things internally and how/when to expose it to customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration feature-request This issue requires a new behavior in the product in order be resolved. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants