You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even though this SDK has shipped/GA'd, marking non-const methods as const is a non-breaking change so we can safely make this update and adhere to the C++ guidelines.
SDK Clients are designed to be immutable as per the guidelines, so it should be safe to mark them as const so that a user referencing client instances as const& will be able to call any of the marked methods:
✅ DO declare all client functions as const since service clients are intended to be immutable.
Even though this SDK has shipped/GA'd, marking non-const methods as const is a non-breaking change so we can safely make this update and adhere to the C++ guidelines.
azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/cryptography/cryptography_client.hpp
Lines 130 to 132 in eaadd48
Other KeyVault Keys clients like
KeyClient
are already correctly marking the methods as const, so we only need to updateCryptographyClient
.azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client.hpp
Lines 123 to 127 in eaadd48
SDK Clients are designed to be immutable as per the guidelines, so it should be safe to mark them as
const
so that a user referencing client instances asconst&
will be able to call any of the marked methods:cc @LarryOsterman, @RickWinter
Similar to:
#6328
#6329
#6330
Codegen issue for context: https://github.com/Azure/autorest.cpp/issues/464
The text was updated successfully, but these errors were encountered: