Use ServiceDirectories from PackageInfo instead of the ChangedServices from diff.json (#45189)

* Use ServiceDirectories from PackageInfo instead of the ChangedServices from diff.json

* comment everything out after the CodeGen verification steps for faster testing

* Changes for testing only

* Revert README changes used for testing and remove commented out ci.yml steps

Author: JimSuplizio

eng/pipelines/templates/jobs/ci.yml

@@ -346,17 +346,21 @@ jobs:
           CheckLinkGuidance: $true
 
       - ${{ if and(eq(variables['Build.Reason'], 'PullRequest'), eq(parameters.ServiceDirectory, 'auto')) }}:
-        # NOTE: The PRServiceDirectories string is used in the two Code Generation steps below
+        # NOTE: The PRServiceDirectories string is used in the two Code Generation steps below and
+        # the verify samples
         - pwsh: |
-            $diffJson = Get-Content '$(Build.ArtifactStagingDirectory)/diff/diff.json' -Raw
-            $diff = ConvertFrom-Json $diffJson
-            $changedServicesString = ''
-            if ($diff.ChangedServices) {
-                $changedServicesString = $diff.ChangedServices -join ","
+            $packageInfoFiles = Get-ChildItem -Path '$(Build.ArtifactStagingDirectory)/PackageInfo' -Filter "*.json" -File
+            $serviceDirectories = @()
+            foreach ($packageInfoFile in $packageInfoFiles) {
+                $packageInfo = Get-Content -Path $packageInfoFile | ConvertFrom-Json
+                $serviceDirectories += $packageInfo.ServiceDirectory
             }
+            # dedupe the list
+            $serviceDirectories = $serviceDirectories | Select-Object -Unique
+            $changedServicesString = $serviceDirectories -join ","
             Write-Host "changedServicesString='$changedServicesString'"
             Write-Host "##vso[task.setvariable variable=PRServiceDirectories;]$changedServicesString"
-          displayName: Set PRServiceDirectories from PR diff
+          displayName: Set PRServiceDirectories from PackageInfo files
       - ${{ else }}:
         - pwsh: |
             $changedServicesString='${{ parameters.ServiceDirectory }}'

sdk/clientcore/annotation-processor/README.md

@@ -56,7 +56,7 @@ The client-core annotation processor for introducing compile-time code generatio
    ```
 2. Annotate your interfaces with `@ServiceInterface`,  `@HttpRequestInformation` and
    `@UnexpectedResponseExceptionDetail` such annotations:
-   ```java 
+   ```java
    @ServiceInterface(name = "ExampleClient", host = "{endpoint}/example")
    public interface ExampleService {
        @HttpRequestInformation(method = HttpMethod.GET, path = "/user/{userId}", expectedStatusCodes = { 200 })
@@ -89,7 +89,7 @@ The client-core annotation processor for introducing compile-time code generatio
       public HttpPipeline getPipeline() {
           return defaultPipeline;
       }
-      
+
       public Response<BinaryData> getUser(String userId, Context context) {
           return getUser(endpoint, apiVersion, userId, context);
       }
@@ -119,7 +119,7 @@ The client-core annotation processor for introducing compile-time code generatio
           if (!expectedResponse) {
               throw new RuntimeException("Unexpected response code: " + responseCode);
           }
-       
+
           networkResponse.close();
           return networkResponse;
       }