Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Enhancement for RetryStrategy #39646

Open
2 tasks done
waynewang1989 opened this issue Apr 10, 2024 · 2 comments
Open
2 tasks done

[FEATURE REQ] Enhancement for RetryStrategy #39646

waynewang1989 opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@waynewang1989
Copy link

Is your feature request related to a problem? Please describe.
Currently , the RetryStrategy can only do calculateRetryDelay within the context. There's no way for a more detailed retry strategy configuration setup. Think of the following scenario:

  1. I want to do fixed delay and retry on response code 429, maximum retry count is 60 times.
  2. For other should retry scenarios, keeps the default strategy.

Describe the solution you'd like
A more fine-grained RetryStrategy configuration interface.

Describe alternatives you've considered

  1. Adding or updating current interface of RetryStrategy to support it.
  2. Adding a new impl of the existing RetryStrategy and when RetryPolicy uses RetryStrategy, check if the configured RetryStrategy is the new one. If not, use the default impl.

Additional context
NA

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 10, 2024
@alzimmermsft alzimmermsft self-assigned this Apr 16, 2024
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 16, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 16, 2024
@alzimmermsft
Copy link
Member

Thank you for filing this feature request @waynewang1989.

Would an API such as RetryStrategy.calculateRetryDelay(RequestRetryConditions) be sufficient to allow your use case?

@alzimmermsft alzimmermsft added needs-author-feedback Workflow: More information is needed from author to address the issue. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Nov 11, 2024
Copy link

Hi @waynewang1989. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-author-feedback Workflow: More information is needed from author to address the issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Status: No status
Development

No branches or pull requests

2 participants