Compile-time codegen feedback

[samvaity]

1. 'defaultPipeline' is not the right name - it is the httpPipeline

2. get rid of the 'getPipeline' method - just use the final field directly.

3. Don't create a 'String host' if the value is only used in one place - just put it directly into that place.

4. Chain the 'create HTTP request' calls, to reduce the number of 'httpRequest.getHeaders().' calls, e.g. rather than this:

// Create the HTTP request

HttpRequest httpRequest = new HttpRequest().setMethod(HttpMethod.POST).setUri(host);

httpRequest.getHeaders().add(HttpHeaderName.CONTENT_LENGTH, String.valueOf(contentLength));

httpRequest.getHeaders().add(HttpHeaderName.CONTENT_TYPE, contentType);

Can you generate this:

// Create the HTTP request

HttpRequest httpRequest = new HttpRequest()

.setMethod(HttpMethod.POST)

.setUri(host)

.getHeaders()

	.add(HttpHeaderName.CONTENT_LENGTH, String.valueOf(contentLength))

	.add(HttpHeaderName.CONTENT_TYPE, contentType);

5. Remember to add in whitespace lines before the various // comments - let's make the generated code pretty

6. Line 94 seems unnecessary: BinaryData binaryData = (BinaryData) data; (where data is already BinaryData)