[AutoPR @azure-arm-netapp]-generated-from-SDK Generation - JS-5617326 #36760
Conversation
…pp/NetApp/tspconfig.yaml', API Version: 2025-09-01-preview, SDK Release Type: beta, and CommitSHA: '97241c594f16e0915407b7dc85377e4e3b26b0b9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5617326 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull request overview
This is an auto-generated PR that updates the Azure NetApp Files SDK samples from API version 2025-09-01 to 2025-09-01-preview. The changes primarily involve:
- Updating package metadata to reflect beta status
- Updating API version references in documentation comments
- Replacing hardcoded subscription IDs with placeholder values
- Adding new sample files for elastic storage features (elastic accounts, pools, volumes, snapshots, backups, etc.)
- Adding new sample files for cache and bucket features
- Redacting sensitive information (passwords, certificate objects)
Reviewed changes
Copilot reviewed 299 out of 603 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updated package name to include "-beta" suffix, changed dependency from "latest" to "next", updated @azure/identity version, added "(Beta)" to description |
| Sample files (.js/.ts) | Updated x-ms-original-file references from 2025-09-01 to 2025-09-01-preview, replaced real subscription IDs with placeholder GUIDs |
| Elastic feature samples | Added comprehensive samples for new elastic storage features including accounts, pools, volumes, snapshots, backup policies and vaults |
| Cache samples | Added new samples for cache management operations |
| Bucket samples | Added new samples for volume bucket operations |
| Active Directory samples | Added new samples for active directory configuration management |
Comments suppressed due to low confidence (4)
sdk/netapp/arm-netapp/samples/v22-beta/javascript/elasticBackupPoliciesDeleteSample.js:1
- The parameter name "snapshotPolicyName" is misleading for an elastic backup policy deletion operation. It should be "backupPolicyName" to match the resource type being deleted and maintain consistency with other elasticBackupPolicies samples.
// Copyright (c) Microsoft Corporation.
sdk/netapp/arm-netapp/samples-dev/elasticBackupPoliciesDeleteSample.ts:1
- The parameter name "snapshotPolicyName" is misleading for an elastic backup policy deletion operation. It should be "backupPolicyName" to match the resource type being deleted and maintain consistency with other elasticBackupPolicies samples.
// Copyright (c) Microsoft Corporation.
sdk/netapp/arm-netapp/samples/v22-beta/javascript/elasticBackupPoliciesDeleteSample.js:1
- The account parameter uses "accountName" while all other samples in this PR use "account1". This inconsistency should be corrected to use "account1" for uniformity.
// Copyright (c) Microsoft Corporation.
sdk/netapp/arm-netapp/samples-dev/elasticBackupPoliciesDeleteSample.ts:1
- The account parameter uses "accountName" while all other samples in this PR use "account1". This inconsistency should be corrected to use "account1" for uniformity.
// Copyright (c) Microsoft Corporation.
| */ | ||
| async function bucketsDelete() { | ||
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9"; |
There was a problem hiding this comment.
The subscription ID should use the standard placeholder "00000000-0000-0000-0000-000000000000" for consistency with other samples in this PR, rather than a different GUID.
| const subscriptionId = "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9"; | |
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; |
| */ | ||
| async function bucketsDelete(): Promise<void> { | ||
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9"; |
There was a problem hiding this comment.
The subscription ID should use the standard placeholder "00000000-0000-0000-0000-000000000000" for consistency with other samples in this PR, rather than a different GUID.
| const subscriptionId = "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9"; | |
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; |
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticSnapshotPolicies.delete("resourceGroup", "accountName", "snapshotPolicyName"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticSnapshotPolicies.delete("resourceGroup", "accountName", "snapshotPolicyName"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticBackups.delete("resourceGroup", "account1", "backupVault1", "backup1"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticBackups.delete("resourceGroup", "account1", "backupVault1", "backup1"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticBackupVaults.delete("resourceGroup", "account1", "backupVault1"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticBackupVaults.delete("resourceGroup", "account1", "backupVault1"); |
There was a problem hiding this comment.
The resource group parameter uses a generic "resourceGroup" value while all other samples in this PR use "myRG". This inconsistency should be corrected to use "myRG" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticSnapshotPolicies.delete("resourceGroup", "accountName", "snapshotPolicyName"); |
There was a problem hiding this comment.
The account parameter uses "accountName" while all other samples in this PR use "account1". This inconsistency should be corrected to use "account1" for uniformity.
| const credential = new DefaultAzureCredential(); | ||
| const subscriptionId = "00000000-0000-0000-0000-000000000000"; | ||
| const client = new NetAppManagementClient(credential, subscriptionId); | ||
| await client.elasticSnapshotPolicies.delete("resourceGroup", "accountName", "snapshotPolicyName"); |
There was a problem hiding this comment.
The account parameter uses "accountName" while all other samples in this PR use "account1". This inconsistency should be corrected to use "account1" for uniformity.
4 participants
Configurations: 'specification/netapp/resource-manager/Microsoft.NetApp/NetApp/tspconfig.yaml', API Version: 2025-09-01-preview, SDK Release Type: beta, and CommitSHA: '97241c594f16e0915407b7dc85377e4e3b26b0b9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5617326 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=eace239f-c2ca-f011-bbd3-6045bd07ef68 Submitted by: [email protected]
Release Plan Details
Spec pull request: [NetApp] fix things that should be in preview azure-rest-api-specs#38806
Spec API version: 2025-09-01-preview